lib: add crypto dependant modules cannotUseCache

[danbev]

This commit adds JavaScript modules that depend on crypto to the cannotUseCache array. This is to avoid having them compiled when node has been configured --without-ssl which currently fails.

With this change the complete testsuite passes again when configured --without-ssl.

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1496/pipeline

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/18337/

[joyeecheung]

This would make the errors different now right? Before it's ERR_NO_CRYPTO, now it's the module not found error?

Also, if just to work around the cache generator - you can just push to the cannotUseCache array in lib/internal/bootstrap/cache.js when process.versions.openssl is falsy, similar to how Intl, trace events and inspector gets skipped - although come to think of it, don't we have no crypto jobs in the CI? @refack

[danbev]

This would make the errors different now right?

I'm not sure, if there are no existing test for those error messages then that might be an issue. All test pass locally for me using --without-ssl (if I also include #24096 but that is a different failure than this one).

Also, if just to work around the cache generator

I was thinking that we exclude the crypto object files when configured without-ssl and thought it made sense to also exclude these, but my main goal here is to get the testsuite to pass with --without-ssl so I'll take a look cannotUseCache. Thanks

[refack]

although come to think of it, don't we have no crypto jobs in the CI? @refack

No. We only have --without-intl and --shared-openssl, but we can do have CONFIG_FLAGS so lets see:
https://ci.nodejs.org/job/node-test-commit/22899/parameters/

[refack]

This commit moves the JavaScript source files that have a crypto dependency to be guarded by node_use_openssl

I'm trying to figure out how to make this more maintainable 🤔 ... Maybe have a blacklist instead of a whitelist (like V8 does for no-intl -

node/deps/v8/gypfiles/v8.gyp

Lines 1892 to 1893 in 7e1b178

	}, { # v8_enable_i18n_support==0
	'sources!': [

)

Or even better (could be in a later PR) parsed the sources and dynamically filter those out in js2c.py.

[danbev]

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/18357/

[danbev]

Landed in 350bef6.