lib: remove useless getLibuvNow in internal/timers#23995
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:internal/timers
Closed
lib: remove useless getLibuvNow in internal/timers#23995ZYSzys wants to merge 1 commit intonodejs:masterfrom zys-contrib:internal/timers
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:internal/timers
Conversation
nodejs-github-bot
added
the
timers
cjihrig
approved these changes
Oct 31, 2018
jasnell
approved these changes
Oct 31, 2018
addaleax
approved these changes
Oct 31, 2018
mmarchini
approved these changes
Oct 31, 2018
lpinca
approved these changes
Oct 31, 2018
ryzokuken
approved these changes
Oct 31, 2018
Member
Trott
added
the
author ready
Member
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18323/ |
Member
|
Landed in 22f5c08 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 4, 2018
PR-URL: nodejs#23995 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 5, 2018
PR-URL: #23995 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
This was referenced Nov 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused
getLibuvNowinlib/internal/timers.jssince we are using this function throughinternalBinding('timers')directly inlib/timers.js.Maybe make bit of optimization ?
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes