tools,gyp: don't force build actions with multiple outputs

[refack]

Excluding macOS which has a different way of resolving dependencies which can lead to deadlocks.

Reroll: #23156
Refs: #23257
Fixes: #23255

Don't add force_append (FORCE_DO_CMD) to the intermediate sentinel.
Adding it makes the action run alway, even when there are no changes.
(refack): AFAICT because *.intermediate files don't have build rules.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1428/pipeline

[refack]

/CC @nodejs/python @nodejs/build-files @nodejs/gyp

[bnoordhuis]

This is the wrong way of doing it. You're effectively ignoring the value of the force argument to WriteMakeRule() here.

The call comes from WriteDoCmd(). Forcing the action to run when it's a command is correct; commands are imperatives. You should try to come up with another way of solving this.

[refack]

Yeah, I know this is a hack. But the soup GYP generates for make is hard to reason about, and empirically this works (it also works on macOS, but might lead to deadlocks when run -jN with N > 1). Works as in rebuilds iff action's file inputs are touched.

I'll give it more thought...

[sam-github]

make -j4 node, after node has just been built (so there is nothing to do), currently relinks node and cctest, and takes over half a minute. That's pretty painful. Will this fix that problem?

[targos]

@sam-github yes. I work with this patch applied:

$ make -j4 node
make -C out BUILDTYPE=Release V=1
make[1]: Nothing to be done for 'all'.
if [ ! -r node -o ! -L node ]; then ln -fs out/Release/node node; fi