src: promote v8 name spaces with using#23934
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:src/util
Closed
src: promote v8 name spaces with using#23934ZYSzys wants to merge 1 commit intonodejs:masterfrom zys-contrib:src/util
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:src/util
Conversation
nodejs-github-bot
added
c++
addaleax
approved these changes
Oct 28, 2018
targos
approved these changes
Oct 28, 2018
cjihrig
approved these changes
Oct 28, 2018
lpinca
approved these changes
Oct 28, 2018
jasnell
approved these changes
Oct 29, 2018
fhinkel
requested changes
Oct 30, 2018
Member
fhinkel
left a comment
fhinkel
left a comment
There was a problem hiding this comment.
Thanks! Could you change the commit message please. I think it should be "for consistency".
Member
Author
|
@fhinkel Aha, sorry for the commit message typo😅. Fixed now. |
fhinkel
approved these changes
Oct 30, 2018
Contributor
Contributor
|
Landed in 9e31a72. |
danbev
pushed a commit
that referenced
this pull request
Nov 2, 2018
PR-URL: #23934 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 2, 2018
PR-URL: #23934 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Nov 15, 2018
Contributor
|
This does not land cleanly in |
2 tasks
2 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Feb 4, 2019
Backport-PR-URL: #25005 PR-URL: #23934 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Backport-PR-URL: #25005 PR-URL: #23934 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote v8 name spaces with using for consistent in
utilrelated codebase.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes