buffer: validate arg for compare

[refack]

Refs: #23840

Makes server-major changes to buf.compare() argument validation, to be in line with docs (require areg to be Number. Disable coerce string like 0xff);

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1367/pipeline

[Trott]

@nodejs/buffer

[Trott]

Semver major, so would need one more approval from @nodejs/tsc.

[mcollina]

LGTM

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/19253/

[Trott]

Seems to break many many tests which I guess is due to changes that happened since this was opened? Anyway, will put this one on hold for now.

[Trott]

Seems to break many many tests which I guess is due to changes that happened since this was opened? Anyway, will put this one on hold for now.