[v10.x backport] src: initial large page (2M) support#23861
[v10.x backport] src: initial large page (2M) support#23861uttampawar wants to merge 1 commit intonodejs:v10.x-stagingfrom
Conversation
eb751c8 to
8fb053a
Compare
|
@addaleax Created this backport PR for new Large Pages Support in v10.x release. I followed all the instructions as stated in backporting-to-release-lines.md document. One step I couldn't do is to run node-test-pull-request CI job due to permission issue. Is this step different than default Travis CI job starts with any new PR changes? Any help is appreciated. |
|
Thank you @uttampawar, here's a CI job: https://ci.nodejs.org/job/node-test-pull-request/18131/ |
refack
left a comment
There was a problem hiding this comment.
Changes to build scaffolding LGTM
RSLGTM on actual implementation.
|
There was a failed test with the workers test-suite, but it Details |
8b431ad to
3f63297
Compare
3f63297 to
8e7a12f
Compare
|
@refack Do I need to do anything for this PR? |
|
@uttampawar the issue behind #23876 was resolved so I'll try to rebase and run a new CI test. |
8fb053a to
ed6b4b5
Compare
|
@targos PTAL for 10.x |
node.gypi
Outdated
There was a problem hiding this comment.
Is this change intentional? If so why is it not in a separate commit (backporting this 2d4dd10)?
There was a problem hiding this comment.
@lundibundi It was not intentional. I'll fix this and update the PR.
There was a problem hiding this comment.
@lundibundi Fixed the accidental deletion of blank line.
Backport-PR-URL: nodejs#23861 PR-URL: nodejs#22079 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
ed6b4b5 to
5ed7244
Compare
|
landed in d1102f8 |
PR-URL: #22079
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Denys Otrishko shishugi@gmail.com
Reviewed-By: Refael Ackermann refack@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes