deps: fix wrong default for v8 handle zapping by refack · Pull Request #23801 · nodejs/node

refack · 2018-10-21T13:05:46Z

Can we devise a test for this?

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-10-21T13:05:47Z

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1325/pipeline

refack · 2018-10-21T13:07:26Z

/CC @nodejs/v8-update @nodejs/build-files

CI: https://ci.nodejs.org/job/node-test-pull-request/18027/

deps/v8/gypfiles/features.gypi

addaleax · 2018-10-21T13:15:17Z

Can we devise a vest for this?

I think we can only catch this through benchmarking, and maybe manually comparing the compiler flags before/after GYP changes.

addaleax · 2018-10-21T13:19:55Z

Also, according to #23182 (comment) I think we should bump the embedder version for GYP updates?

targos

Does it work if we force it to 1 in common.gypi?

addaleax

Running CI to verify that this works: https://ci.nodejs.org/job/node-test-pull-request/18029/

doesn’t seem to work for Debug builds yet

refack · 2018-10-21T17:05:25Z

Does it work if we force it to 1 in common.gypi?

Yes, if we force it (i.e. without %) in common.gypi to config.gypi

refack · 2018-10-21T17:12:55Z

Does it work if we force it to 1 in common.gypi?

Yes, if we force it (i.e. without %) in common.gypi to config.gypi

No, I think it's because of the issue resolved by #23704

Running just debug vs regular CI: https://ci.nodejs.org/job/node-test-commit-linux-containered/8006/

refack · 2018-10-21T17:23:01Z

https://ci.nodejs.org/job/node-test-commit-linux-containered/8007/

refack · 2018-10-21T17:33:10Z

Sample from debug build https://ci.nodejs.org/job/node-test-commit-linux-containered/8007/nodes=ubuntu1604_sharedlibs_debug_x64/console):

Release target (no zapping)

ccache
g++
-o
/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/out/Release/obj.target/v8_base/deps/v8/src/debug/debug-scopes.o
../deps/v8/src/debug/debug-scopes.cc
'-DV8_GYP_BUILD'
'-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0'
'-DV8_TARGET_ARCH_X64'
'-DV8_EMBEDDER_STRING="-node.6"'
'-DENABLE_DISASSEMBLER'
'-DV8_PROMISE_INTERNAL_FIELD_COUNT=1'
'-DV8_INTL_SUPPORT'
'-DV8_CONCURRENT_MARKING'
'-DDISABLE_UNTRUSTED_CODE_MITIGATIONS'
'-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC'
'-DUCONFIG_NO_SERVICE=1'
'-DU_ENABLE_DYLOAD=0'
'-DU_STATIC_IMPLEMENTATION=1'
'-DU_HAVE_STD_STRING=1'
'-DUCONFIG_NO_BREAK_ITERATION=0'
-I../deps/v8
-I../.
-I/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/out/Release/obj/gen
-I../deps/v8/include
-I../deps/icu-small/source/i18n
-I../deps/icu-small/source/common

-pthread
-Wall
-Wextra
-Wno-unused-parameter
-m64
-fno-strict-aliasing
-m64
-fdata-sections
-ffunction-sections
-O3
-O3
-fno-omit-frame-pointer
-fno-rtti
-fno-exceptions
-std=gnu++1y
-MMD
-MF
/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/out/Release/.deps//home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/out/Release/obj.target/v8_base/deps/v8/src/debug/debug-scopes.o.d.raw
-c

Debug target (has '-DENABLE_HANDLE_ZAPPING'):

ccache
g++
-o
/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/out/Debug/obj.target/v8_base/deps/v8/src/compiler/jump-threading.o
../deps/v8/src/compiler/jump-threading.cc
'-DV8_GYP_BUILD'
'-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0'
'-DV8_TARGET_ARCH_X64'
'-DV8_EMBEDDER_STRING="-node.6"'
'-DENABLE_DISASSEMBLER'
'-DV8_PROMISE_INTERNAL_FIELD_COUNT=1'
'-DV8_INTL_SUPPORT'
'-DV8_CONCURRENT_MARKING'
'-DDISABLE_UNTRUSTED_CODE_MITIGATIONS'
'-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC'
'-DUCONFIG_NO_SERVICE=1'
'-DU_ENABLE_DYLOAD=0'
'-DU_STATIC_IMPLEMENTATION=1'
'-DU_HAVE_STD_STRING=1'
'-DUCONFIG_NO_BREAK_ITERATION=0'
'-DV8_ENABLE_CHECKS'
'-DOBJECT_PRINT'
'-DVERIFY_HEAP'
'-DDEBUG'
'-DV8_TRACE_MAPS'
'-DV8_ENABLE_ALLOCATION_TIMEOUT'
'-DV8_ENABLE_FORCE_SLOW_PATH'
'-DENABLE_SLOW_DCHECKS'
'-D_DEBUG'
'-DENABLE_HANDLE_ZAPPING'
-I../deps/v8
-I../.
-I/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/out/Debug/obj/gen
-I../deps/v8/include
-I../deps/icu-small/source/i18n
-I../deps/icu-small/source/common
-pthread
-Wall
-Wextra
-Wno-unused-parameter
-m64
-fno-strict-aliasing
-m64
-Woverloaded-virtual
-fdata-sections
-ffunction-sections
-g
-O0
-fno-rtti
-fno-exceptions
-std=gnu++1y
-MMD
-MF
/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/out/Debug/.deps//home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/out/Debug/obj.target/v8_base/deps/v8/src/compiler/jump-threading.o.d.raw
-c

refack · 2018-10-21T17:34:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/18031/

addaleax

👍

refack · 2018-10-23T13:27:06Z

@nodejs/v8-update @nodejs/build-files PTAL
(this solve a regression (#23796) that since #23182 we build Release binaries with -DENABLE_HANDLE_ZAPPING which has a performance penalty)

refack · 2018-10-23T14:08:51Z

Resume: https://ci.nodejs.org/job/node-test-pull-request/18074/

PR-URL: nodejs#23801 Fixes: nodejs#23796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

PR-URL: #23801 Fixes: #23796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Oct 21, 2018

refack mentioned this pull request Oct 21, 2018

V8 gyp file refactor performance regression #23796

Closed

addaleax reviewed Oct 21, 2018

View reviewed changes

deps/v8/gypfiles/features.gypi Outdated Show resolved Hide resolved

refack force-pushed the fix-handle-zapping branch 2 times, most recently from 80e3b52 to c460808 Compare October 21, 2018 15:41

targos reviewed Oct 21, 2018

View reviewed changes

addaleax previously approved these changes Oct 21, 2018

View reviewed changes

refack self-assigned this Oct 22, 2018

refack mentioned this pull request Oct 22, 2018

Investigate flaky test-fs-readfile-tostring-fail #16601

Closed

addaleax approved these changes Oct 23, 2018

View reviewed changes

targos approved these changes Oct 23, 2018

View reviewed changes

targos mentioned this pull request Oct 23, 2018

2018-10-30 Version 10.13.0 'Dubnium' (LTS) #23831

Merged

mmarchini approved these changes Oct 23, 2018

View reviewed changes

mmarchini added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 23, 2018

deps: fix wrong default for v8 handle zapping

c9b49a6

PR-URL: nodejs#23801 Fixes: nodejs#23796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

refack force-pushed the fix-handle-zapping branch from 86b66a9 to c9b49a6 Compare October 23, 2018 14:58

refack merged commit c9b49a6 into nodejs:master Oct 23, 2018

refack deleted the fix-handle-zapping branch October 23, 2018 15:01

refack removed their assignment Oct 24, 2018

MylesBorins added the land-on-10.x label Oct 25, 2018

targos mentioned this pull request Oct 27, 2018

Release proposal: v11.1.0 #23922

Merged

littledivy mentioned this pull request Feb 11, 2023

Explicitly set v8_enable_handle_zapping to false denoland/rusty_v8#1188

Merged

Uh oh!

Conversation

refack commented Oct 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Oct 21, 2018

Uh oh!

refack commented Oct 21, 2018

Uh oh!

Uh oh!

addaleax commented Oct 21, 2018

Uh oh!

addaleax commented Oct 21, 2018

Uh oh!

targos left a comment

Choose a reason for hiding this comment

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

refack commented Oct 21, 2018

Uh oh!

refack commented Oct 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

refack commented Oct 21, 2018

Uh oh!

refack commented Oct 21, 2018

Uh oh!

refack commented Oct 21, 2018

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

refack commented Oct 23, 2018

Uh oh!

refack commented Oct 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

refack commented Oct 21, 2018 •

edited

Loading

refack commented Oct 21, 2018 •

edited

Loading