src: use more explicit return type in Sign::SignFinal()#23779
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
src: use more explicit return type in Sign::SignFinal()#23779addaleax wants to merge 2 commits intonodejs:masterfrom
addaleax wants to merge 2 commits intonodejs:masterfrom
Conversation
Using the non-indexed variant of `std::get<>` broke Travis CI. Also, this allows us to be a bit more concise when returning from `SignFinal()` due to some error condition. Refs: nodejs#23427
nodejs-github-bot
added
c++
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/18003/ (:heavy_check_mark:) Feel free to 👍 this comment to approve fast-tracking. (There’s also #23778, but I think it might be best to talk about those changes independently) |
refack
reviewed
Oct 20, 2018
Contributor
refack
left a comment
refack
left a comment
There was a problem hiding this comment.
Looks like a good idea, but I feel like I need to give it another look tomorrow.
Member
Author
|
@refack Done! |
joyeecheung
approved these changes
Oct 20, 2018
tniessen
approved these changes
Oct 20, 2018
refack
approved these changes
Oct 20, 2018
Contributor
|
IMHO this is not a clear cut case for fast-tracking, but it does resolve a regression, and the change itself has small footprint. So I'm 👍. |
cjihrig
approved these changes
Oct 20, 2018
Contributor
|
This exposed a bug in our release cluster, the arm64 cross compiler (centos7-arm64) is using gcc4.8. |
Member
Author
|
Landed in 20282b1 |
addaleax
added a commit
that referenced
this pull request
Oct 21, 2018
Using the non-indexed variant of `std::get<>` broke Travis CI. Also, this allows us to be a bit more concise when returning from `SignFinal()` due to some error condition. Refs: #23427 PR-URL: #23779 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 21, 2018
Using the non-indexed variant of `std::get<>` broke Travis CI. Also, this allows us to be a bit more concise when returning from `SignFinal()` due to some error condition. Refs: #23427 PR-URL: #23779 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
|
Should this be backported to |
BethGriggs
pushed a commit
that referenced
this pull request
Oct 18, 2019
Using the non-indexed variant of `std::get<>` broke Travis CI. Also, this allows us to be a bit more concise when returning from `SignFinal()` due to some error condition. Refs: #23427 PR-URL: #23779 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the non-indexed variant of
std::get<>broke Travis CI.Also, this allows us to be a bit more concise when returning
from
SignFinal()due to some error condition.Refs: #23427
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes