Icu4c 63.1 by srl295 · Pull Request #23715 · nodejs/node

srl295 · 2018-10-17T16:49:23Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

The usual 63.1 bump:

icu 63.1 bump (CLDR 34) …
- The following languages have been added to ICU: Sindhi, Maori, Turkmen, Javanese, Interlingua, Kurdish (ku), Xhosa, plus many data improvements.
- Japanese new era testing support
Full release notes: http://site.icu-project.org/download/63

Also, support URL failover for downloading ICU (full-icu mode). I added 2 extra URLs.
Note shiny new github URL as primary!

nodejs-github-bot · 2018-10-17T16:49:25Z

@srl295 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1275/pipeline

srl295 · 2018-10-19T20:35:25Z

confirmed that #22156 is fixed with this merge

cclauss · 2018-10-21T08:55:26Z

tools/configure.d/nodedownload.py

Please put from __future__ import print_function at the top of this file above other imports and then use the print() function instead of the print statement to be ready for Python 3. There are 437 days until Python 2 end of life.

@cclauss thanks, will do.

refack

Python changes LGTM with nit fixed
ICU bump RSLGTM

cclauss

LGTM, thanks.

richardlau

Build files/tools changes LGTM.
RSLGTM ICU bump.

srl295 · 2018-10-23T01:55:02Z

https://ci.nodejs.org/job/node-test-pull-request/18058/ if i did it right

srl295 · 2018-10-23T20:46:14Z

should be semver minor

srl295 · 2018-10-24T00:16:22Z

restarted ci https://ci.nodejs.org/job/node-test-pull-request/18091/

srl295 · 2018-10-24T03:44:14Z

Ci now good

mhdawson

Rubber stamp LGTM

Building on nodejs#23269, if multiple ICU download URLs are present, try the next one in case of error. Part of the ICU 63.1 bump, but independent code-wise. nodejs#23244 PR-URL: nodejs#23715 Fixes: nodejs#22344 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

cclauss · 2018-10-24T15:49:44Z

Awesome work here! Thanks.

Building on #23269, if multiple ICU download URLs are present, try the next one in case of error. Part of the ICU 63.1 bump, but independent code-wise. #23244 PR-URL: #23715 Fixes: #22344 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

- Full release notes: http://site.icu-project.org/download/63 Fixes: #22344 PR-URL: #23715 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Notable changes: * deps * Updated ICU to 63.1. #23715 * repl * Top-level for-await-of is now supported in the REPL. #23841 * timers * Fixed an issue that could cause timers to enter an infinite loop. #23870 PR-URL: #23922

- Full release notes: http://site.icu-project.org/download/63 Fixes: nodejs#22344 PR-URL: nodejs#23715 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Notable changes: * deps * Updated ICU to 63.1. #23715 * repl * Top-level for-await-of is now supported in the REPL. #23841 * timers * Fixed an issue that could cause timers to enter an infinite loop. #23870 PR-URL: #23922

Fake PR-URL for testing: PR-URL: nodejs/node#23715

Building on #23269, if multiple ICU download URLs are present, try the next one in case of error. Part of the ICU 63.1 bump, but independent code-wise. #23244 PR-URL: #23715 Fixes: #22344 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

- Full release notes: http://site.icu-project.org/download/63 Fixes: #22344 PR-URL: #23715 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Building on #23269, if multiple ICU download URLs are present, try the next one in case of error. Part of the ICU 63.1 bump, but independent code-wise. #23244 PR-URL: #23715 Fixes: #22344 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

- Full release notes: http://site.icu-project.org/download/63 Fixes: #22344 PR-URL: #23715 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Building on #23269, if multiple ICU download URLs are present, try the next one in case of error. Part of the ICU 63.1 bump, but independent code-wise. #23244 PR-URL: #23715 Fixes: #22344 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

- Full release notes: http://site.icu-project.org/download/63 Fixes: #22344 PR-URL: #23715 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Notable changes: - deps: - icu 63.1 bump (CLDR 34) (Steven R. Loomis) [#23715](#23715) - upgrade npm to 6.9.0 (Kat Marchán) [#26244](#26244) - upgrade openssl sources to 1.1.1a (Sam Roberts) [#25381](#25381) - upgrade to libuv 1.24.1 (cjihrig) [#25078](#25078) - events: add once method to use promises with EventEmitter (Matteo Collina) [#26078](#26078) - n-api: mark thread-safe function as stable (Gabriel Schulhof) [#25556](#25556) - repl: support top-level for-await-of (Shelley Vohr) [#23841](#23841) - zlib: - add brotli support (Anna Henningsen) [#24938](#24938) PR-URL: #27514

Building on nodejs#23269, if multiple ICU download URLs are present, try the next one in case of error. Part of the ICU 63.1 bump, but independent code-wise. nodejs#23244 PR-URL: nodejs#23715 Fixes: nodejs#22344 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> (cherry picked from commit d8f2d27)

Fake PR-URL for testing: PR-URL: nodejs/node#23715

srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Oct 17, 2018

srl295 self-assigned this Oct 17, 2018

srl295 requested a review from refack October 17, 2018 16:49

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 17, 2018

This was referenced Oct 17, 2018

Some fixes for Python 3 #23669

Closed

Intl.NumberFormat disregards maximumSignificantDigits #22156

Closed

srl295 mentioned this pull request Oct 19, 2018

deps: icu: apply workaround patch to 62.1 for significant digits #23764

Merged

3 tasks

srl295 requested a review from devsnek October 19, 2018 20:57

cclauss reviewed Oct 21, 2018

View reviewed changes

refack approved these changes Oct 22, 2018

View reviewed changes

cclauss approved these changes Oct 23, 2018

View reviewed changes

richardlau approved these changes Oct 23, 2018

View reviewed changes

srl295 force-pushed the icu4c-63.1 branch from f28cdae to d451ac0 Compare October 23, 2018 01:54

richardlau added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 23, 2018

devsnek approved these changes Oct 24, 2018

View reviewed changes

mhdawson approved these changes Oct 24, 2018

View reviewed changes

srl295 closed this Oct 24, 2018

srl295 force-pushed the icu4c-63.1 branch from d451ac0 to 6786ff4 Compare October 24, 2018 15:28

srl295 merged commit 6786ff4 into nodejs:master Oct 24, 2018

srl295 deleted the icu4c-63.1 branch October 24, 2018 16:57

targos mentioned this pull request Oct 27, 2018

Release proposal: v11.1.0 #23922

Merged

richardlau mentioned this pull request Nov 5, 2018

deps: ICU4C 63.1 #23244

Closed

rvagg added a commit to nodejs/changelog-maker that referenced this pull request Nov 9, 2018

minor nit

cc442b6

Fake PR-URL for testing: PR-URL: nodejs/node#23715

BethGriggs mentioned this pull request May 1, 2019

v10.16.0 proposal #27514

Merged

renawolford6 added a commit to renawolford6/changelog-maker-javascript that referenced this pull request Nov 9, 2022

minor nit

d7a9c2a

Fake PR-URL for testing: PR-URL: nodejs/node#23715

Uh oh!

Conversation

srl295 commented Oct 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Oct 17, 2018

Uh oh!

srl295 commented Oct 19, 2018

Uh oh!

cclauss Oct 21, 2018

Choose a reason for hiding this comment

Uh oh!

srl295 Oct 22, 2018

Choose a reason for hiding this comment

Uh oh!

refack left a comment

Choose a reason for hiding this comment

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

richardlau left a comment

Choose a reason for hiding this comment

Uh oh!

srl295 commented Oct 23, 2018

Uh oh!

srl295 commented Oct 23, 2018

Uh oh!

srl295 commented Oct 24, 2018

Uh oh!

srl295 commented Oct 24, 2018

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

cclauss commented Oct 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

srl295 commented Oct 17, 2018 •

edited

Loading