test: fix timeout in sequential/test-fs-watch-system-limit

[mmmscott]

Timeout in this test can occur on Linux if machine is able to handle
200 child processes that are spawned.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[jasnell]

This likely isn't the best way to handle this. Our test runner will generally catch the timeout and fail the test as is.

/cc @nodejs/testing

[addaleax]

Fwiw, this is a re-do of #23560

I’m not sure either… it doesn’t seem great (maybe we could skip the test instead of marking it as passing?), but the test is only supposed to check the error message, so this might be okay…

[mmmscott]

as I was trying alternative options, I attempted to skip the test, but since the error stream expects at least one call, the tests were failing.

I'm happy to make any changes, but off the top of my head I couldn't think of anything that would successful pass the test without upping the number of child processes that could get spawned.

[Trott]

Would it make sense to move the test file from sequential to pummel and not modify it?

[addaleax]

@Trott I would be okay with moving it there, yes…

[Trott]

@marcusscott Would you be OK updating this to move the test unchanged from the sequential directory to the pummel directory instead of adding a timeout? Spawning 200 child processes seems like something that perhaps ought to only happen if the user asks for tests that might strain resources.

[mmmscott]

sure thing, makes sense to me!

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/18354/

[jasnell]

Landed in e492f92