test: updating assertion and expect order in test-tls-client-verify.js#23547
Closed
eitah wants to merge 1 commit intonodejs:masterfrom
Closed
test: updating assertion and expect order in test-tls-client-verify.js#23547eitah wants to merge 1 commit intonodejs:masterfrom
eitah wants to merge 1 commit intonodejs:masterfrom
Conversation
targos
added
the
code-and-learn
jasnell
approved these changes
Oct 12, 2018
trivikr
approved these changes
Oct 12, 2018
BridgeAR
approved these changes
Oct 12, 2018
cjihrig
approved these changes
Oct 12, 2018
gireeshpunathil
approved these changes
Oct 13, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 15, 2018
PR-URL: nodejs#23547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 15, 2018
PR-URL: nodejs#23547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
Author
|
Thanks Ruben :)🦄
…On Mon, Oct 15, 2018, 3:24 AM Ruben Bridgewater ***@***.***> wrote:
Landed in 0f17c1c
<0f17c1c>
🎉
@eitah <https://github.com/eitah> congratulations on your commit to
Node.js!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23547 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ASanVfEUWIIFgTTevtyIHqYrtwFOW7-Oks5ulGJjgaJpZM4XZ6m_>
.
|
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
PR-URL: #23547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Oct 20, 2018
PR-URL: #23547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
PR-URL: #23547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #23547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes[ ] documentation is changed or added