lib: remove unused 'e' from catch#23458
Closed
pdxmholmes wants to merge 1 commit intonodejs:masterfrom
pdxmholmes:querystring-unused-variable
Closed
lib: remove unused 'e' from catch#23458pdxmholmes wants to merge 1 commit intonodejs:masterfrom pdxmholmes:querystring-unused-variable
pdxmholmes wants to merge 1 commit intonodejs:masterfrom
pdxmholmes:querystring-unused-variable
Conversation
nodejs-github-bot
added
the
querystring
gireeshpunathil
added
the
code-and-learn
gireeshpunathil
approved these changes
Oct 12, 2018
cjihrig
approved these changes
Oct 12, 2018
targos
added
code-and-learn
digitalinfinity
approved these changes
Oct 12, 2018
addaleax
approved these changes
Oct 12, 2018
Member
|
@pdxmholmes - is it possible to add a commit message to this PR? thanks. |
Contributor
Author
Unless I am missing something, it has one? I didn't feel like the change was large enough to require more than a one liner, but I'm happy to try and think up more detail if it's needed. |
jasnell
approved these changes
Oct 12, 2018
Member
thefourtheye
approved these changes
Oct 13, 2018
Contributor
thefourtheye
left a comment
thefourtheye
left a comment
There was a problem hiding this comment.
Hmmm, I thought our linter caught unused variables.
Member
|
Collaborators, please 👍 here to approve fast-tracking. |
Trott
added
fast-track
Member
It does but it makes exceptions in some situations and this is one of them. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 13, 2018
PR-URL: nodejs#23458 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Member
|
Landed in 68b4637. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
addaleax
pushed a commit
that referenced
this pull request
Oct 14, 2018
PR-URL: #23458 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
PR-URL: #23458 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
PR-URL: #23458 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23458 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #23458 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes