util: update definition of DISALLOW_COPY_AND_ASSIGN macro#23092
Closed
nitsakh wants to merge 1 commit intonodejs:masterfrom
Closed
util: update definition of DISALLOW_COPY_AND_ASSIGN macro#23092nitsakh wants to merge 1 commit intonodejs:masterfrom
nitsakh wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
bnoordhuis
approved these changes
Sep 26, 2018
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. You're right they're not needed. I believe I added them to work around bugs in VS 2013 and left them in afterwards as self-documentation.
jasnell
approved these changes
Sep 28, 2018
Member
addaleax
added
lib / src
Contributor
Contributor
|
Re-run failing node-test-commit-osx. |
Contributor
|
Landed in 97f1e94. |
danbev
pushed a commit
that referenced
this pull request
Oct 2, 2018
PR-URL: #23092 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
PR-URL: #23092 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 10, 2018
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
DISALLOW_COPY_AND_ASSIGNmacro.The compiler will not define move constructor or move assignment operators when copy constructor/assignment is defined.
Hence, it's not needed to
deletemove operations.This also makes the definition coherent with chromium's definition of the same. https://cs.chromium.org/chromium/src/base/macros.h?rcl=b209442fa2c29021b06a6dcbbd0486b440011fe2&l=33.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes