Closed
Conversation
nodejs-github-bot
added
the
libuv
addaleax
approved these changes
Sep 21, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Fixes: https://github.com/nodejs/node/issues/22814
Member
addaleax
added
the
author ready
jasnell
approved these changes
Sep 21, 2018
Member
|
Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20943/ |
Contributor
|
Landed in 2790db5. |
danbev
pushed a commit
that referenced
this pull request
Sep 24, 2018
PR-URL: #22997 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 24, 2018
PR-URL: #22997 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
After talking a bit with @addaleax, I did a bisect using a series of stress tests to determine what commit introduced the unreliability for Ref: https://gist.github.com/Trott/d3c3b5e4419497fdc8651ac2d5f805c7 |
Member
|
Went through the individual libuv commits in nodejs/reliability#18 (comment) |
This was referenced Oct 10, 2018
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Nov 5, 2018
PR-URL: nodejs#22997 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes