tools: merge custom cpplint with cpplint v1.3.0#22864
Closed
boneskull wants to merge 1 commit intonodejs:masterfrom
Closed
tools: merge custom cpplint with cpplint v1.3.0#22864boneskull wants to merge 1 commit intonodejs:masterfrom
boneskull wants to merge 1 commit intonodejs:masterfrom
Conversation
Merged https://github.com/cpplint/cpplint/blob/master/cpplint.py with our customized version to enable better IDE/editor integration. Made file executable.
addaleax
approved these changes
Sep 14, 2018
addaleax
added
c++
Contributor
|
Funny... I was just about to check for updates myself (but I was looking at https://github.com/google/styleguide/blob/gh-pages/cpplint/cpplint.py) |
Contributor
danbev
approved these changes
Sep 18, 2018
Contributor
|
Just to improve my understanding, do we have the customisations which we did to that file documented somewhere? |
Contributor
We do have customisations but I'm not aware of any documentation of them apart from in the docstrings in the source ( |
Contributor
|
Landed in fee4d3a. |
danbev
pushed a commit
that referenced
this pull request
Sep 18, 2018
Merged https://github.com/cpplint/cpplint/blob/master/cpplint.py with our customized version to enable better IDE/editor integration. Made file executable. PR-URL: #22864 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 18, 2018
Merged https://github.com/cpplint/cpplint/blob/master/cpplint.py with our customized version to enable better IDE/editor integration. Made file executable. PR-URL: #22864 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 19, 2018
Merged https://github.com/cpplint/cpplint/blob/master/cpplint.py with our customized version to enable better IDE/editor integration. Made file executable. PR-URL: #22864 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2018
Merged https://github.com/cpplint/cpplint/blob/master/cpplint.py with our customized version to enable better IDE/editor integration. Made file executable. PR-URL: #22864 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that I was having trouble running cpplint against Node.js from within VSCode; the official version is incompatible with our rules, and our customized version is incompatible with the extension.
My tests are failing on
debug test-http-same-map, butmake lint-cpppasses.Merged https://github.com/cpplint/cpplint/blob/master/cpplint.py with
our customized version to enable better IDE/editor integration.
Made file executable.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes