Closed
Conversation
I, uhm, might have messed up by using a `substr(start, end)` signature when `std::string` actually uses `substr(start, len)`. Fix that. Fixes: nodejs#22526 Refs: nodejs#22392
nodejs-github-bot
added
the
c++
addaleax
added
cli
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/16754/ I have labeled this |
devsnek
approved these changes
Aug 26, 2018
BridgeAR
approved these changes
Aug 26, 2018
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the quick fix.
mscdex
reviewed
Aug 26, 2018
| // eslint-disable-next-line no-template-curly-in-string | ||
| expect('--trace-event-file-pattern {pid}-${rotation}.trace_events', 'B\n'); | ||
| // eslint-disable-next-line no-template-curly-in-string | ||
| expect('--trace-event-file-pattern {pid}-${rotation}.trace_events ' + |
Contributor
There was a problem hiding this comment.
Is it possible we could avoid hard-coding all of these options somehow with 22490 or would that require too much node options metadata to know what (if any) arguments to pass for each?
Member
Author
There was a problem hiding this comment.
I think it would work for a number of options (mostly the simple boolean ones), but there are quite a few that change output in some way…
refack
approved these changes
Aug 26, 2018
Contributor
|
Simple fixes for regressions, should be fast tracked. |
Member
Member
trivikr
approved these changes
Aug 26, 2018
Member
Author
|
Landed in 1c05b16 |
addaleax
added a commit
that referenced
this pull request
Aug 26, 2018
I, uhm, might have messed up by using a `substr(start, end)` signature when `std::string` actually uses `substr(start, len)`. Fix that. Fixes: #22526 Refs: #22392 PR-URL: #22529 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
added a commit
that referenced
this pull request
Aug 28, 2018
I, uhm, might have messed up by using a `substr(start, end)` signature when `std::string` actually uses `substr(start, len)`. Fix that. Fixes: #22526 Refs: #22392 PR-URL: #22529 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
I, uhm, might have messed up by using a `substr(start, end)` signature when `std::string` actually uses `substr(start, len)`. Fix that. Fixes: #22526 Refs: #22392 PR-URL: #22529 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
I, uhm, might have messed up by using a `substr(start, end)` signature when `std::string` actually uses `substr(start, len)`. Fix that. Fixes: #22526 Refs: #22392 PR-URL: #22529 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I, uhm, might have messed up by using a
substr(start, end)signature whenstd::stringactually usessubstr(start, len). Fix that.Fixes: #22526
Refs: #22392
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes