src: export node_is_initialized#225
src: export node_is_initialized#225zcbenz wants to merge 1 commit intonodejs:v1.xfrom zcbenz:export-node_is_initialized
Conversation
|
I don't really want to export a global (before you ask: |
|
How about putting |
That seems reasonable to me. |
|
I have updated the patch. |
|
@piscisaureus LGTY? |
|
LGTM but a comment explaining why node_is_initialized is set where it's set makes it less likely to break in a future refactoring. |
This can make node_is_initialized correctly set to true for applications that use node::Init to embed iojs.
|
I have added some comments in the code to make things clear. |
This can make node_is_initialized correctly set to true for applications that use node::Init to embed iojs. PR-URL: #225 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks Cheng, landed in 22e1aea. |
This gives users that using io.js as external library a chance to set
node_is_initializedtotrue, otherwise it would impossible for them to use dynamic native modules.