Skip to content

[8.x] v8 bug fixes for s390x#22375

Closed
john-yan wants to merge 1 commit intonodejs:v8.x-stagingfrom
john-yan:v8.x-staging
Closed

[8.x] v8 bug fixes for s390x#22375
john-yan wants to merge 1 commit intonodejs:v8.x-stagingfrom
john-yan:v8.x-staging

Conversation

@john-yan
Copy link

@john-yan john-yan commented Aug 17, 2018 •
edited by BethGriggs
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project. v8.x labels Aug 17, 2018
@john-yan john-yan mentioned this pull request Aug 17, 2018
Closed
@john-yan
Copy link
Author

john-yan commented Aug 17, 2018

issue: #22364

@john-yan john-yan changed the title V8.x staging v8 bug fixes for s390x Aug 17, 2018
@john-yan
Copy link
Author

john-yan commented Aug 17, 2018

Could anyone please advice where should the small test described in the issue should go into?

@mscdex
Copy link
Contributor

mscdex commented Aug 17, 2018

I'm not sure the V8 version should be bumped, but definitely the v8_embedder_string in common.gypi needs to be bumped.

@devsnek
Copy link
Member

devsnek commented Aug 17, 2018

commit links to ca95cd9 but the correct hash is 9040405eb952124d24b37c501f8eb4456fc318da

@richardlau
Copy link
Member

richardlau commented Aug 17, 2018

I'm not sure the V8 version should be bumped, but definitely the v8_embedder_string in common.gypi needs to be bumped.

Bumping the V8 version is correct for 8.x (v8_embedder_string doesn't exist in this branch) https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#backporting-to-abandoned-branches

@joransiu
Copy link
Contributor

joransiu commented Aug 17, 2018

Could anyone please advice where should the small test described in the issue should go into?

Perhaps contribute the failing testcase to the V8 tests?

@MylesBorins
Copy link
Contributor

MylesBorins commented Aug 17, 2018

V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1614/

deps: cherry-pick 9040405 from upstream V8
8b5a1e6 
Original commit message:

  s390x: fix high 32-bit word corruption issue

  [email protected]

  Change-Id: I9a2cf0f3e4a33dc4b86c83acfefcd27968bbcdb4
  Reviewed-on: https://chromium-review.googlesource.com/1176424
  Reviewed-by: Joran Siu <[email protected]>
  Commit-Queue: Junliang Yan <[email protected]>
  Cr-Commit-Position: refs/heads/master@{nodejs#55143}

Refs: v8/v8@ca95cd9
@john-yan
Copy link
Author

john-yan commented Aug 18, 2018 •
edited
Loading

Thanks @devsnek for pointing out. The message is updated.

mhdawson
mhdawson approved these changes Aug 20, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looked at past history and cherrypicks like this did bunch the patch level

@mhdawson
Copy link
Member

mhdawson commented Aug 20, 2018

@BethGriggs any chance to can review and then land if there are no objections before then?

@mhdawson
Copy link
Member

mhdawson commented Aug 20, 2018

The CI started by @MylesBorins was green :)

@BethGriggs
Copy link
Member

BethGriggs commented Aug 21, 2018

@MylesBorins, how long does this PR need before it can be merged into v8.x-staging? Could it make the v8.12.0 release on September 4th?

@jasnell jasnell changed the title v8 bug fixes for s390x [8.x] v8 bug fixes for s390x Aug 21, 2018
BethGriggs pushed a commit that referenced this pull request Aug 23, 2018
@BethGriggs
deps: V8: cherry-pick 9040405 from upstream
5294919 
Original commit message:

  s390x: fix high 32-bit word corruption issue

  [email protected]

  Change-Id: I9a2cf0f3e4a33dc4b86c83acfefcd27968bbcdb4
  Reviewed-on: https://chromium-review.googlesource.com/1176424
  Reviewed-by: Joran Siu <[email protected]>
  Commit-Queue: Junliang Yan <[email protected]>
  Cr-Commit-Position: refs/heads/master@{#55143}

Refs: v8/v8@ca95cd9

PR-URL: #22375
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@BethGriggs
Copy link
Member

BethGriggs commented Aug 23, 2018

Landed in 5294919

@BethGriggs BethGriggs closed this Aug 23, 2018
@MylesBorins MylesBorins mentioned this pull request Sep 3, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
Open
This was referenced Aug 5, 2021
Open
Open
This was referenced Aug 5, 2021
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 15, 2021
Open
@molllyn1 molllyn1 mentioned this pull request Mar 22, 2024
Open
@137717unity 137717unity mentioned this pull request Mar 22, 2024
Open
@kissofire kissofire mentioned this pull request Mar 22, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Mar 22, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Mar 22, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@john-yan @mscdex @devsnek @richardlau @joransiu @MylesBorins @mhdawson @BethGriggs @nodejs-github-bot