src: extract common DoBind and DoConnect methods by maclover7 · Pull Request #22315 · nodejs/node

maclover7 · 2018-08-14T14:38:45Z

TCPWrap::Bind and TCPWrap::Bind6 share a large amount of functionality, so a common DoBind was extracted to remove duplication. TCPWrap::Connect/TCPWrap::Connect6 follow this same pattern, so DoConnect was extracted from those two methods to also remove duplication.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2018-08-14T14:38:46Z

@maclover7 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/558/pipeline

jasnell · 2018-08-14T15:31:59Z

The change looks fine but can you include a quick description of the rationale in the commit log and PR description?

maclover7 · 2018-08-16T23:32:09Z

Full CI: https://ci.nodejs.org/job/node-test-pull-request/16505/

addaleax · 2018-08-19T10:05:05Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/16565/

joyeecheung · 2018-08-20T01:13:14Z

This PR needs a rebase against master to avoid the git failure in the CI.

addaleax · 2018-08-25T00:03:11Z

@maclover7 Can you rebase?

jasnell · 2018-09-10T18:28:46Z

Ping @maclover7

maclover7 · 2018-11-29T19:13:38Z

@addaleax @jasnell Rebased — sorry for my delay

`TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of functionality, so a common `Bind` was extracted to remove duplication.

addaleax

Still LGTM

maclover7 · 2018-11-30T16:48:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19086/

maclover7 · 2018-12-03T18:21:21Z

Passing Resume Build: https://ci.nodejs.org/job/node-test-pull-request/19153/

maclover7 · 2018-12-03T18:21:58Z

Could use another review or two @nodejs/collaborators

indutny

LGTM if CI is happy. Thanks!

indutny · 2018-12-03T18:26:16Z

src/tcp_wrap.cc

-  sockaddr_in addr;
-  int err = uv_ip4_addr(*ip_address, port, &addr);
+  if (family == AF_INET6 &&
+      !args[2]->Uint32Value(env->context()).To(&flags)) return;


Does this pass lint? I'd rather put return on a next line and add braces on this line and the line after return.

ronkorving · 2018-12-05T06:39:18Z

I have to share a somewhat amusing observation that while the intention of this PR is to reduce code (redundancy), GitHub measures it to remove as many lines as it adds (+23 −23).

While I can appreciate the sentiment, I see this as increasing complexity in order to remove code duplication, shrinking the code base by 0 lines.

-0 on this one.

maclover7 · 2018-12-17T01:00:25Z

Fixed @indutny's comment

New CI: https://ci.nodejs.org/job/node-test-pull-request/19590/ ✔️

maclover7 · 2018-12-17T21:41:20Z

Landed in 4b96a2a

`TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of functionality, so a common `Bind` was extracted to remove duplication. PR-URL: #22315 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

`TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of functionality, so a common `Bind` was extracted to remove duplication. PR-URL: nodejs#22315 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

`TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of functionality, so a common `Bind` was extracted to remove duplication. Backport-PR-URL: nodejs#28222 PR-URL: nodejs#22315 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

`TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of functionality, so a common `Bind` was extracted to remove duplication. Backport-PR-URL: #28222 PR-URL: #22315 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem. labels Aug 14, 2018

jasnell approved these changes Aug 14, 2018

View reviewed changes

BridgeAR requested a review from addaleax August 17, 2018 15:41

addaleax approved these changes Aug 19, 2018

View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 19, 2018

joyeecheung mentioned this pull request Aug 20, 2018

CI failures: 20180820 nodejs/reliability#15

Closed

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 25, 2018

Trott mentioned this pull request Nov 15, 2018

Bangalore, November 17th nodejs/code-and-learn#88

Closed

src: extract common Bind method

0697900

`TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of functionality, so a common `Bind` was extracted to remove duplication.

addaleax approved these changes Nov 30, 2018

View reviewed changes

indutny approved these changes Dec 3, 2018

View reviewed changes

lundibundi approved these changes Dec 5, 2018

View reviewed changes

fixup: indutny style comment

c55c6b2

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2018

maclover7 closed this Dec 17, 2018

maclover7 deleted the jm-extract-tcp branch December 17, 2018 21:41

MylesBorins mentioned this pull request Dec 25, 2018

v11.6.0 proposal #25175

Merged

BethGriggs added the backport-requested-v10.x label Mar 14, 2019

BethGriggs mentioned this pull request Jun 14, 2019

[v10.x-backport] src: extract common Bind method #28222

Closed

4 tasks

BethGriggs removed the backport-requested-v10.x label Jun 14, 2019

BethGriggs mentioned this pull request Jul 17, 2019

v10.16.1 proposal #28731

Merged

Uh oh!

Conversation

maclover7 commented Aug 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Aug 14, 2018

Uh oh!

jasnell commented Aug 14, 2018

Uh oh!

maclover7 commented Aug 16, 2018

Uh oh!

addaleax commented Aug 19, 2018

Uh oh!

joyeecheung commented Aug 20, 2018

Uh oh!

addaleax commented Aug 25, 2018

Uh oh!

jasnell commented Sep 10, 2018

Uh oh!

maclover7 commented Nov 29, 2018

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

maclover7 commented Nov 30, 2018

Uh oh!

maclover7 commented Dec 3, 2018

Uh oh!

maclover7 commented Dec 3, 2018

Uh oh!

indutny left a comment

Choose a reason for hiding this comment

Uh oh!

indutny Dec 3, 2018

Choose a reason for hiding this comment

Uh oh!

ronkorving commented Dec 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maclover7 commented Dec 17, 2018 • edited by Trott Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maclover7 commented Dec 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

maclover7 commented Aug 14, 2018 •

edited

Loading

ronkorving commented Dec 5, 2018 •

edited

Loading

maclover7 commented Dec 17, 2018 •

edited by Trott

Loading