Skip to content

src: move process.binding('signal_wrap') to internalBinding#22290

Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell:sigwrap-internalbinding
Closed

src: move process.binding('signal_wrap') to internalBinding#22290
jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell:sigwrap-internalbinding

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Aug 12, 2018

Refs: #22160

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 12, 2018
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 12, 2018

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/541/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels Aug 12, 2018
@jasnell jasnell mentioned this pull request Aug 12, 2018
Closed
33 tasks
@BridgeAR BridgeAR requested a review from a team August 13, 2018 00:32
@BridgeAR
Copy link
Member

BridgeAR commented Aug 13, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/16409/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 13, 2018
jdalton
jdalton suggested changes Aug 13, 2018
View reviewed changes
Copy link
Member

@jdalton jdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding removals until migration is ironed out

@jasnell jasnell force-pushed the sigwrap-internalbinding branch from f3a3bf0 to a8c7129 Compare August 15, 2018 02:20
@jasnell
Copy link
Member Author

jasnell commented Aug 15, 2018

@jdalton ... added to the fallthrough whitelist

@jasnell
Copy link
Member Author

jasnell commented Aug 15, 2018

New CI: https://ci.nodejs.org/job/node-test-pull-request/16463/

@jasnell
Copy link
Member Author

jasnell commented Aug 15, 2018

Linux-containered rerun: https://ci.nodejs.org/job/node-test-commit-linux-containered/6284/
Arm rerun: https://ci.nodejs.org/job/node-test-commit-arm/17735/

@jasnell
Copy link
Member Author

jasnell commented Aug 15, 2018

ping @nodejs/tsc

@jasnell jasnell requested a review from a team August 16, 2018 18:28
@jasnell
Copy link
Member Author

jasnell commented Aug 16, 2018

Need one more @nodejs/tsc sign off for this to land.

@jasnell
Copy link
Member Author

jasnell commented Aug 16, 2018

New CI: https://ci.nodejs.org/job/node-test-pull-request/16493/

@jasnell jasnell force-pushed the sigwrap-internalbinding branch from a8c7129 to 4920d37 Compare August 16, 2018 19:42
@jasnell
Copy link
Member Author

jasnell commented Aug 16, 2018

/cc @nodejs/build ... Linux-containered CI failed again for unrelated reasons: https://ci.nodejs.org/job/node-test-commit-linux-containered/6329/

@maclover7
Copy link
Contributor

maclover7 commented Aug 16, 2018

@jasnell Fix for CI is in #22340

@joyeecheung joyeecheung mentioned this pull request Aug 17, 2018
Closed
@jasnell
Copy link
Member Author

jasnell commented Aug 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16530/

@jasnell jasnell force-pushed the sigwrap-internalbinding branch from 4920d37 to 05cc6a6 Compare August 18, 2018 13:30
@jasnell
Copy link
Member Author

jasnell commented Aug 18, 2018

Trying again: https://ci.nodejs.org/job/node-test-pull-request/16535/

@jasnell
Copy link
Member Author

jasnell commented Aug 18, 2018

ping @nodejs/tsc ... need one more TSC sign off on this please.

@jasnell jasnell force-pushed the sigwrap-internalbinding branch 2 times, most recently from 9fd3dde to 910efff Compare August 18, 2018 23:33
@jasnell jasnell force-pushed the sigwrap-internalbinding branch from 910efff to 5436dfd Compare August 19, 2018 20:21
@jasnell
Copy link
Member Author

jasnell commented Aug 19, 2018

CI after rebasing: https://ci.nodejs.org/job/node-test-pull-request/16581/

jasnell added a commit that referenced this pull request Aug 19, 2018
@jasnell
src: move process.binding('signal_wrap') to internalBinding
0bdb95f 
PR-URL: #22290
Refs: #22160
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Aug 19, 2018

Landed in 0bdb95f

@jasnell jasnell closed this Aug 19, 2018
@joyeecheung joyeecheung mentioned this pull request Aug 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

+2 more reviewers

@jdalton jdalton jdalton approved these changes

@maclover7 maclover7 maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jasnell @nodejs-github-bot @BridgeAR @maclover7 @jdalton @cjihrig @joyeecheung @trivikr