inspector: tie objects lifetime to the thread they belong to#22242
Merged
eugeneo merged 0 commit intonodejs:masterfrom Aug 14, 2018
eugeneo:objects_live_in_thread
Merged
inspector: tie objects lifetime to the thread they belong to#22242eugeneo merged 0 commit intonodejs:masterfrom eugeneo:objects_live_in_thread
eugeneo merged 0 commit intonodejs:masterfrom
eugeneo:objects_live_in_thread
Conversation
nodejs-github-bot
added
the
c++
jasnell
approved these changes
Aug 10, 2018
Member
trivikr
added
the
author ready
Contributor
Author
|
Fixed Visual C++ compilation. |
alexkozy
approved these changes
Aug 13, 2018
Contributor
Author
|
Windows CI failure is #21425 |
Contributor
Author
rvagg
pushed a commit
that referenced
this pull request
Aug 15, 2018
PR-URL: #22242 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
This was referenced Aug 16, 2018
firass111
pushed a commit
to firass111/Project_node1
that referenced
this pull request
Apr 16, 2025
PR-URL: nodejs/node#22242 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis is needed for #21364