src: use available ReqWrap instance for libuv req#21980
Closed
maclover7 wants to merge 2 commits intonodejs:masterfrom
maclover7:jm-use-reqwrap
Closed
src: use available ReqWrap instance for libuv req#21980maclover7 wants to merge 2 commits intonodejs:masterfrom maclover7:jm-use-reqwrap
maclover7 wants to merge 2 commits intonodejs:masterfrom
maclover7:jm-use-reqwrap
Conversation
Use available `ReqWrap` descendant to make call to libuv -- avoid doing call with the `ReqWrap`'s request member and then calling `Dispatched()` afterwards.
nodejs-github-bot
added
c++
addaleax
approved these changes
Jul 26, 2018
Member
|
CI: https://ci.nodejs.org/job/node-test-pull-request/16014/ (edit: ✔️) |
addaleax
added
the
author ready
apapirovski
approved these changes
Jul 26, 2018
devsnek
approved these changes
Jul 26, 2018
cjihrig
approved these changes
Jul 27, 2018
jasnell
approved these changes
Jul 27, 2018
Contributor
Author
|
Landed in 51a50a0 |
maclover7
added a commit
that referenced
this pull request
Jul 28, 2018
Use available `ReqWrap` descendant to make call to libuv -- avoid doing call with the `ReqWrap`'s request member and then calling `Dispatched()` afterwards. PR-URL: #21980 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2018
Use available `ReqWrap` descendant to make call to libuv -- avoid doing call with the `ReqWrap`'s request member and then calling `Dispatched()` afterwards. PR-URL: #21980 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use available
ReqWrapdescendant to make call to libuv -- avoid doingcall with the
ReqWrap's request member and then callingDispatched()afterwards.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes