test: update setTimeout on file test/internet/test-net-connect-unref.js to use common.platformTimeout#21969
test: update setTimeout on file test/internet/test-net-connect-unref.js to use common.platformTimeout#21969conectado wants to merge 3 commits intonodejs:masterfrom
Conversation
|
Even better IMO would be to remove the |
|
Also: Welcome @conectado! Thanks for the pull request! |
|
@Trott First and foremost thanks for the feedback! I've started reading the Edit: I've continued reading that file, and found out that on line 1440 all arguments are converted to |
Changes the time used by the last line of the file to normalize the timeout by using the common library.
Removes the setTimeout since if the test were to fail it would time out due to the tools/test.py wrapper
Trott
added
the
author ready
|
I updated the PR, since the constant |
|
👍 here to fast-track. |
|
Landed in 586a7a4. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Removes the setTimeout since if the test were to fail it would time out due to the tools/test.py wrapper PR-URL: nodejs#21969 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau Ugh, I forgot to push it. It's pushed now. (Thanks!) |
|
Landed in 586a7a4. |
|
Thanks everyone!! |
Removes the setTimeout since if the test were to fail it would time out due to the tools/test.py wrapper PR-URL: #21969 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
7 participants
Hi!
This is my first PR 😄 I'm sorry if I make any mistake.
This commit updates the time used on the
timeOutfunction to confonform to the recomendation given by the guide on writing tests.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes