[v10.x] lib,src: replace all C++ promises with JS promises#21879
Closed
targos wants to merge 1 commit intonodejs:v10.x-stagingfrom
Closed
[v10.x] lib,src: replace all C++ promises with JS promises#21879targos wants to merge 1 commit intonodejs:v10.x-stagingfrom
targos wants to merge 1 commit intonodejs:v10.x-stagingfrom
Conversation
C++ promises can not be properly optimized by V8. They also behave a tiny bit different than "regular" promises. PR-URL: nodejs#20830 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
added
promises
Member
Author
Member
Author
Member
|
@targos can we be sure there is no performance degradation with this backport to older V8? |
Member
Author
|
@benjamingr The V8 in 10.x is the same as master. |
Member
Author
|
Ping |
BridgeAR
approved these changes
Jul 24, 2018
benjamingr
approved these changes
Jul 24, 2018
targos
pushed a commit
that referenced
this pull request
Jul 24, 2018
C++ promises can not be properly optimized by V8. They also behave a tiny bit different than "regular" promises. PR-URL: #20830 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Backport-PR-URL: #21879 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Member
Author
|
Landed in 9817e40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #20830
/cc @BridgeAR