src: remove unnecessary else#21874
Closed
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-rm-else
Closed
src: remove unnecessary else#21874maclover7 wants to merge 1 commit intonodejs:masterfrom maclover7:jm-rm-else
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-rm-else
Conversation
Argument is not used by the only caller.
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Jul 19, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Also a problem that would go away if we were to use template inheritance … :)
trivikr
approved these changes
Jul 19, 2018
jasnell
approved these changes
Jul 19, 2018
Contributor
Author
cjihrig
approved these changes
Jul 19, 2018
maclover7
added
the
author ready
Contributor
Author
|
Landed in b016d98 |
maclover7
added a commit
that referenced
this pull request
Jul 22, 2018
Argument is not used by the only caller. PR-URL: #21874 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 24, 2018
Argument is not used by the only caller. PR-URL: #21874 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced Aug 1, 2018
This was referenced Jun 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argument is not used by the only caller.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes