test: move AEAD test vectors out of script#21873
Closed
tniessen wants to merge 2 commits intonodejs:masterfrom
Closed
test: move AEAD test vectors out of script#21873tniessen wants to merge 2 commits intonodejs:masterfrom
tniessen wants to merge 2 commits intonodejs:masterfrom
Conversation
lpinca
reviewed
Jul 18, 2018
test/fixtures/aead-vectors.js
Outdated
| tag: 'd0c515f4d1cdd4fdac4f02ab', | ||
| tampered: true | ||
| } | ||
| ]; No newline at end of file |
lpinca
approved these changes
Jul 18, 2018
trivikr
approved these changes
Jul 19, 2018
jasnell
approved these changes
Jul 19, 2018
maclover7
approved these changes
Jul 19, 2018
Contributor
maclover7
added
the
author ready
Member
Author
|
Thanks @maclover7! Whatever node-test-commit-custom-suites is, it failed... Resumed in https://ci.nodejs.org/job/node-test-pull-request/15964/ |
Member
Author
|
Landed in b2ac3af. |
tniessen
added a commit
that referenced
this pull request
Jul 22, 2018
PR-URL: #21873 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Contributor
|
Member
|
Depends on #21447 to land on |
targos
added
backport-requested-v10.x
and removed
author ready
targos
pushed a commit
that referenced
this pull request
Aug 29, 2018
PR-URL: #21873 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #21873 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
PR-URL: #21873 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the test by almost 700 lines (more than 50%!). This would optimally be a JSON file, but we should keep the comments, so it remains JS for now.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes