src: add HandleWrap::AddWrapMethods#21769
Closed
maclover7 wants to merge 2 commits intonodejs:masterfrom
maclover7:jm-handle-common
Closed
src: add HandleWrap::AddWrapMethods#21769maclover7 wants to merge 2 commits intonodejs:masterfrom maclover7:jm-handle-common
maclover7 wants to merge 2 commits intonodejs:masterfrom
maclover7:jm-handle-common
Conversation
Extracts common setters to a single location
nodejs-github-bot
added
c++
addaleax
approved these changes
Jul 11, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Thanks!
Just fyi, I’d love to eventually move to using real function template inheritance for this :)
Contributor
Author
jasnell
reviewed
Jul 11, 2018
src/handle_wrap.cc
Outdated
|
|
||
|
|
||
| void HandleWrap::AddWrapMethods(Environment* env, | ||
| Local<FunctionTemplate> t) { |
Member
There was a problem hiding this comment.
nit: indent alignment is slightly off on this line
jasnell
approved these changes
Jul 11, 2018
JungMinu
approved these changes
Jul 12, 2018
BridgeAR
approved these changes
Jul 12, 2018
BridgeAR
added
the
author ready
joyeecheung
approved these changes
Jul 13, 2018
Contributor
Author
|
CI before landing: https://ci.nodejs.org/job/node-test-pull-request/15848/ |
Contributor
Author
|
Landed in 45732c7 |
maclover7
added a commit
that referenced
this pull request
Jul 13, 2018
Extracts common setters to a single location PR-URL: #21769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
added
backport-requested-v10.x
and removed
author ready
Member
|
Should land cleanly on v10.x-staging after #21458 |
targos
pushed a commit
that referenced
this pull request
Jul 14, 2018
Extracts common setters to a single location PR-URL: #21769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
This was referenced Jul 18, 2018
This was referenced Jun 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts common setters to a single location
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes