n-api: remove experimental gate from status codes#21680
Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Closed
n-api: remove experimental gate from status codes#21680gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
gabrielschulhof
force-pushed
the
remove-experimental-from-enum
branch
from
8ef99e4 to
4bf404e
Compare
devsnek
approved these changes
Jul 6, 2018
lpinca
approved these changes
Jul 6, 2018
cjihrig
approved these changes
Jul 6, 2018
Contributor
Author
Contributor
Author
addaleax
approved these changes
Jul 9, 2018
gabrielschulhof
force-pushed
the
remove-experimental-from-enum
branch
from
4bf404e to
4100ba7
Compare
Contributor
Author
|
Rebase and CI: https://ci.nodejs.org/job/node-test-pull-request/15771/ |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Jul 9, 2018
Re: nodejs#21226 (comment) PR-URL: nodejs#21680 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Contributor
Author
|
Landed in 1529ef4. |
targos
pushed a commit
that referenced
this pull request
Jul 10, 2018
Re: #21226 (comment) PR-URL: #21680 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes