Revert "src: move context bootstrap to js"#21587
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
This reverts commit d13cdd9.
nodejs-github-bot
added
c++
3 tasks
refack
approved these changes
Jun 29, 2018
Member
Author
benjamingr
approved these changes
Jun 29, 2018
2 tasks
Member
Author
|
Narrower alternative fix in #21589 |
Member
Author
|
Closing in favor of #21589 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d13cdd9.
The commit causes
nodeto segfault if it is build--without-intl. This fact was revealed in CI testing, but alas, trust in CI infra is low enough that it was likely deemed an infra problem. I have some things to suggest around that, but first...let's fix the build, shall we?👍 here to fast-track. (Fast-tracking is permitted for changes that unbreak CI. CI has been red due to this issue since it landed.)
@devsnek @refack @nodejs/build
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes