Skip to content

doc: add bcoe as collaborator#21536

Closed
bcoe wants to merge 1 commit intonodejs:masterfrom
bcoe:add-ben-as-collaborator
Closed

doc: add bcoe as collaborator#21536
bcoe wants to merge 1 commit intonodejs:masterfrom
bcoe:add-ben-as-collaborator

Conversation

@bcoe
Copy link
Contributor

@bcoe bcoe commented Jun 25, 2018 •
edited
Loading

adding Ben Coe as collaborator.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@bcoe bcoe added doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs. labels Jun 25, 2018
@bcoe bcoe requested a review from Trott June 25, 2018 23:06
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 25, 2018

@bcoe build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/160/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 25, 2018
addaleax
addaleax approved these changes Jun 25, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for being so patient with us, and: Welcome!! 💙

@bcoe
Copy link
Contributor Author

bcoe commented Jun 25, 2018

ci: https://ci.nodejs.org/job/node-test-pull-request-lite/895/

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 25, 2018
@Trott
Copy link
Member

Trott commented Jun 25, 2018

+1 to fast-tracking, not that we need to explicitly fast-track this thing, but you know, hey, someone else want to +1 the fast-tracking anyway?

@mmarchini
Copy link
Contributor

mmarchini commented Jun 25, 2018

not that we need to explicitly fast-track this thing

I think it would be good as part of the Onboarding process :)

@bcoe
Copy link
Contributor Author

bcoe commented Jun 25, 2018

Landed in 198c872

@bcoe bcoe closed this Jun 25, 2018
@bcoe bcoe deleted the add-ben-as-collaborator branch June 25, 2018 23:21
bcoe pushed a commit that referenced this pull request Jun 25, 2018
doc: add bcoe as collaborator
198c872 
PR-URL: #21536
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
targos pushed a commit that referenced this pull request Jun 26, 2018
@targos
doc: add bcoe as collaborator
c050279 
PR-URL: #21536
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

+2 more reviewers

@hiroppy hiroppy hiroppy approved these changes

@mmarchini mmarchini mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bcoe @nodejs-github-bot @Trott @mmarchini @addaleax @hiroppy