errors: fix ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK#21492
Closed
ChALkeR wants to merge 1 commit intonodejs:masterfrom
Closed
errors: fix ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK#21492ChALkeR wants to merge 1 commit intonodejs:masterfrom
ChALkeR wants to merge 1 commit intonodejs:masterfrom
Conversation
This restores a broken and erroneously removed error, which was accidentially renamed to ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK (notice the "INTST" vs "INST") in 921fb84 (PR nodejs#16874) and then had documentation and implementation removed under the old name in 6e1c25c (PR nodejs#18857), as it appeared unused. This error code never worked or was documented under the mistyped name ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back to ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK is a semver-patch fix. Refs: nodejs#21440 Refs: nodejs#21470 Refs: nodejs#16874 Refs: nodejs#18857
nodejs-github-bot
added
the
errors
Member
Author
|
Eh, I accidentially confused Travis here. Re-run doesn't help. |
|
|
||
| > Stability: 1 - Experimental | ||
|
|
||
| An [ES6 module][] loader hook specified `format: 'dynamic` but did not provide a |
Contributor
There was a problem hiding this comment.
`format: 'dynamic` — missing single quote.
ChALkeR
added
invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores a broken and erroneously removed error, which was accidentially renamed to
ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK(notice theINTSTvsINST) in 921fb84 (PR #16874) and then had documentation and implementation removed under the old name in 6e1c25c (PR #18857), as it appeared unused.This error code never worked or was documented under the mistyped name
ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back toERR_MISSING_DYNAMIC_INSTANTIATE_HOOKis a semver-patch fix.Refs: #21440, #21470, #16874, #18857.
This is a part of the fixes hinted by #21470, which includes some tests for error codes usage and documentation and enforces a stricter format.
This is mostly a revert, and specific tests for esm loader actually emitting that error are not included here.
Generic tests for error codes are included in a separate PR: #21470.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes