inspector: add debugging for WebSocket messages#21473
inspector: add debugging for WebSocket messages#21473TimothyGu wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
PR-URL: nodejs#21473 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com>
TimothyGu
force-pushed
the
debug-inspector
branch
from
77f9e8d to
f940c7a
Compare
|
Landed in 8836a0d. |
PR-URL: #21473 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #21473 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@TimothyGu I think this may have been undone by 39977db … should we re-apply changes along these lines? |
|
@addaleax 😞yeah I think this PR could be super helpful for folks trying to develop new Inspector-based front ends. Unfortunately I won't have time to get to it. |
|
@eugeneo ^^^ |
|
This would have to be reimplemented... I was unable to keep the functionality when I was doing the refactor (I believe there was something about debug being invoked on a wrong thread) - so this would have to be reimplemented. The problem on the main thread had been there was no UTF8 message but UTF16 wrapped into v8_inspector::StringBuffer. |
|
@eugeneo oh i already started working on it... i'm also moving Debug off of env because its application scoped not env scoped. |
6 participants
Useful for seeing how DevTools does something with Node.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes