Conversation
Running `license-builder.sh` seems to indicate that there have been some license changes that have not been propagated to our LICENSE file yet. Here they are.
|
Anybody know what's up with the http_parser license text that is removed? |
|
👍 here for fast-tracking. |
|
Thanks for updating. Perhaps in another PR we can consider how to keep things in step, either as a test or part of the build process. |
|
@Trott is there any reason why we shouldn't be just running Will it make backporting harder? |
Seems like a good idea to me. Or write a test that does that so it can be caught during
I don't see how, but there could be something I'm missing. |
Running `license-builder.sh` seems to indicate that there have been some license changes that have not been propagated to our LICENSE file yet. Here they are. PR-URL: nodejs#21472 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
|
Landed in 1e7ff81 |
That's what I meant :-). |
Running `license-builder.sh` seems to indicate that there have been some license changes that have not been propagated to our LICENSE file yet. Here they are. PR-URL: #21472 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Running `license-builder.sh` seems to indicate that there have been some license changes that have not been propagated to our LICENSE file yet. Here they are. PR-URL: #21472 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Running
license-builder.shseems to indicate that there have been somelicense changes that have not been propagated to our LICENSE file yet.
Here they are.
@richardlau
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes