deps: upgrade to libuv 1.21.0 by cjihrig · Pull Request #21466 · nodejs/node

cjihrig · 2018-06-22T15:47:00Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

nodejs-github-bot · 2018-06-22T15:47:01Z

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/121/pipeline

cjihrig · 2018-06-22T15:47:15Z

CI: https://ci.nodejs.org/job/node-test-commit/19388/

EDIT: Only CI failure is #21457.

richardlau · 2018-06-22T15:55:06Z

deps/uv/ChangeLog

I guess something went awry with the changelog generation.

targos · 2018-06-22T16:16:12Z

build: add a cmake build file (Ben Noordhuis)

First step into a "Build Node.js with CMake" option?

addaleax

Non-deps/ changes LGTM

cjihrig · 2018-06-22T17:27:42Z

First step into a "Build Node.js with CMake" option?

You'd have to ask @bnoordhuis 😄

bnoordhuis · 2018-06-22T19:00:32Z

First step into a "Build Node.js with CMake" option?

My cmake branch currently uses a bespoke CMakeLists.txt to build libuv but now that one exists upstream, I'll probably start using that.

santigimeno

LGTM the 2 commits other than mine.

jasnell

Can you include the short change summary in the pr message? just highpoints. :-)

There is already a check in place to prevent stdin and the IPC channel from sharing a file descriptor. This commit adds a similar check to stdout and stderr. Refs: libuv/libuv#1851 Refs: libuv/libuv#1897 PR-URL: nodejs#21466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

So it doesn't fail when creating a socket whose `fd` is already being watched. Test that functionality now inside a cluster worker. Refs: libuv/libuv#1851 Refs: libuv/libuv#1897 PR-URL: nodejs#21466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: - Building via cmake is now supported. PR-URL: libuv/libuv#1850 - Stricter checks have been added to prevent watching the same file descriptor multiple times. PR-URL: libuv/libuv#1851 Refs: nodejs#3604 - An IPC deadlock on Windows has been fixed. PR-URL: libuv/libuv#1843 Fixes: nodejs#9706 Fixes: nodejs#7657 - uv_fs_lchown() has been added. PR-URL: libuv/libuv#1826 Refs: nodejs#19868 - uv_fs_copyfile() sets errno on error. PR-URL: libuv/libuv#1881 Fixes: nodejs#21329 - uv_fs_fchmod() supports -A files on Windows. PR-URL: libuv/libuv#1819 Refs: nodejs#12803 PR-URL: nodejs#21466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

cjihrig · 2018-06-25T00:56:56Z

Landed in cb261c8, 49e5f0a, and 537a4ba.

There is already a check in place to prevent stdin and the IPC channel from sharing a file descriptor. This commit adds a similar check to stdout and stderr. Refs: libuv/libuv#1851 Refs: libuv/libuv#1897 PR-URL: #21466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

So it doesn't fail when creating a socket whose `fd` is already being watched. Test that functionality now inside a cluster worker. Refs: libuv/libuv#1851 Refs: libuv/libuv#1897 PR-URL: #21466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: - Building via cmake is now supported. PR-URL: libuv/libuv#1850 - Stricter checks have been added to prevent watching the same file descriptor multiple times. PR-URL: libuv/libuv#1851 Refs: #3604 - An IPC deadlock on Windows has been fixed. PR-URL: libuv/libuv#1843 Fixes: #9706 Fixes: #7657 - uv_fs_lchown() has been added. PR-URL: libuv/libuv#1826 Refs: #19868 - uv_fs_copyfile() sets errno on error. PR-URL: libuv/libuv#1881 Fixes: #21329 - uv_fs_fchmod() supports -A files on Windows. PR-URL: libuv/libuv#1819 Refs: #12803 PR-URL: #21466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

* dist-indexer: fix libuv version generation Beginning in nodejs/node@537a4ba, `deps/uv/include/uv-version.h` moved to `deps/uv/include/uv/version.h`, so add that as a possible path where libuv's version might be stored. Refs: nodejs/node#21466

There is already a check in place to prevent stdin and the IPC channel from sharing a file descriptor. This commit adds a similar check to stdout and stderr. Refs: libuv/libuv#1851 Refs: libuv/libuv#1897 PR-URL: nodejs#21466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: - Building via cmake is now supported. PR-URL: libuv/libuv#1850 - Stricter checks have been added to prevent watching the same file descriptor multiple times. PR-URL: libuv/libuv#1851 Refs: nodejs#3604 - An IPC deadlock on Windows has been fixed. PR-URL: libuv/libuv#1843 Fixes: nodejs#9706 Fixes: nodejs#7657 - uv_fs_lchown() has been added. PR-URL: libuv/libuv#1826 Refs: nodejs#19868 - uv_fs_copyfile() sets errno on error. PR-URL: libuv/libuv#1881 Fixes: nodejs#21329 - uv_fs_fchmod() supports -A files on Windows. PR-URL: libuv/libuv#1819 Refs: nodejs#12803 PR-URL: nodejs#21466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

There is already a check in place to prevent stdin and the IPC channel from sharing a file descriptor. This commit adds a similar check to stdout and stderr. Backport-PR-URL: #24103 Refs: libuv/libuv#1851 Refs: libuv/libuv#1897 PR-URL: #21466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: - Building via cmake is now supported. PR-URL: libuv/libuv#1850 - Stricter checks have been added to prevent watching the same file descriptor multiple times. PR-URL: libuv/libuv#1851 Refs: #3604 - An IPC deadlock on Windows has been fixed. PR-URL: libuv/libuv#1843 Fixes: #9706 Fixes: #7657 - uv_fs_lchown() has been added. PR-URL: libuv/libuv#1826 Refs: #19868 - uv_fs_copyfile() sets errno on error. PR-URL: libuv/libuv#1881 Fixes: #21329 - uv_fs_fchmod() supports -A files on Windows. PR-URL: libuv/libuv#1819 Refs: #12803 Backport-PR-URL: #24103 PR-URL: #21466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Jun 22, 2018

richardlau reviewed Jun 22, 2018

View reviewed changes

deps/uv/ChangeLog Outdated

Copy link

Member

richardlau Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess something went awry with the changelog generation.

cjihrig reacted with laugh emoji

addaleax approved these changes Jun 22, 2018

View reviewed changes

bnoordhuis approved these changes Jun 22, 2018

View reviewed changes

santigimeno approved these changes Jun 22, 2018

View reviewed changes

jasnell approved these changes Jun 22, 2018

View reviewed changes

This was referenced Jun 22, 2018

unix,win: merge timers implementation libuv/libuv#1882

Merged

fs: undeprecate lchown() #21498

Merged

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 24, 2018

cjihrig force-pushed the libuv branch from f13db2f to 8768964 Compare June 25, 2018 00:21

cjihrig and others added 3 commits June 24, 2018 20:53

cjihrig force-pushed the libuv branch from 8768964 to 537a4ba Compare June 25, 2018 00:55

cjihrig merged commit 537a4ba into nodejs:master Jun 25, 2018

cjihrig deleted the libuv branch June 25, 2018 00:56

targos mentioned this pull request Jul 3, 2018

v10.6.0 proposal #21629

Merged

maclover7 mentioned this pull request Aug 1, 2018

dist-indexer: fix libuv version generation nodejs/nodejs-dist-indexer#6

Merged

MylesBorins mentioned this pull request Nov 5, 2018

[v8.x] Update libuv #24103

Closed

BethGriggs mentioned this pull request Nov 12, 2018

v8.13.0 proposal #23974

Merged

beevelop mentioned this pull request Nov 20, 2018

2018-11-20 Version 8.13.0 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#250

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

deps: upgrade to libuv 1.21.0#21466

deps: upgrade to libuv 1.21.0#21466
cjihrig merged 3 commits intonodejs:masterfrom
cjihrig:libuv

cjihrig commented Jun 22, 2018

Uh oh!

nodejs-github-bot commented Jun 22, 2018

Uh oh!

cjihrig commented Jun 22, 2018 •

edited

Loading

Uh oh!

richardlau Jun 22, 2018

Uh oh!

targos commented Jun 22, 2018

Uh oh!

addaleax left a comment

Uh oh!

cjihrig commented Jun 22, 2018

Uh oh!

bnoordhuis commented Jun 22, 2018

Uh oh!

santigimeno left a comment

Uh oh!

jasnell left a comment

Uh oh!

cjihrig commented Jun 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

cjihrig commented Jun 22, 2018

Checklist

Uh oh!

nodejs-github-bot commented Jun 22, 2018

Uh oh!

cjihrig commented Jun 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

targos commented Jun 22, 2018

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig commented Jun 22, 2018

Uh oh!

bnoordhuis commented Jun 22, 2018

Uh oh!

santigimeno left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig commented Jun 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cjihrig commented Jun 22, 2018 •

edited

Loading