Updated worker-threads.md to include --experimental-worker flag#21461
Closed
jsmrcaga wants to merge 1 commit intonodejs:masterfrom
Closed
Updated worker-threads.md to include --experimental-worker flag#21461jsmrcaga wants to merge 1 commit intonodejs:masterfrom
jsmrcaga wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
added
worker
Member
|
CI: https://ci.nodejs.org/job/node-test-pull-request-lite/888/ Node collaborators, 👍 if you agree with fast-tracking this. |
cjihrig
approved these changes
Jun 22, 2018
targos
approved these changes
Jun 22, 2018
devsnek
approved these changes
Jun 22, 2018
vsemozhetbyt
approved these changes
Jun 22, 2018
Contributor
lpinca
approved these changes
Jun 22, 2018
jasnell
approved these changes
Jun 22, 2018
TimothyGu
approved these changes
Jun 22, 2018
trivikr
approved these changes
Jun 23, 2018
thefourtheye
approved these changes
Jun 23, 2018
Contributor
|
So should we land this as is or wait for |
Updated worker-threads.md, cli.md and node.1 to include --experimental-worker flag
Contributor
Author
|
Hi everyone, updated cli.md and node.1 . Have never used mdoc files, so tell me if anything is wrong! |
Contributor
|
@nodejs/documentation If there are no objections re the last commit, let's land tomorrow? |
Contributor
vsemozhetbyt
added
the
author ready
addaleax
removed
the
fast-track
Member
|
Landed in 467a307, thanks for the PR! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Jun 26, 2018
Updated worker-threads.md, cli.md and node.1 to include --experimental-worker flag PR-URL: #21461 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 28, 2018
Updated worker-threads.md, cli.md and node.1 to include --experimental-worker flag PR-URL: #21461 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist