build: build addons in parallel on Windows#21403
Closed
bzoz wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Port nodejs#21155 to vcbuild.bat
nodejs-github-bot
added
build
Contributor
Author
Contributor
Author
|
On my box this reduces addon build time from 100 to 40 seconds. |
cjihrig
approved these changes
Jun 19, 2018
refack
approved these changes
Jun 19, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
Jun 21, 2018
richardlau
reviewed
Jun 21, 2018
| setlocal | ||
| set npm_config_nodedir=%~dp0 | ||
| "%node_exe%" "%~dp0tools\build-addons.js" "%~dp0deps\npm\node_modules\node-gyp\bin\node-gyp.js" "%~dp0test\addons" | ||
| if errorlevel 1 exit /b 1 |
Member
There was a problem hiding this comment.
Should this be a neq 0 test like the code block it replaces?
Contributor
There was a problem hiding this comment.
This is more CMD idiomatic (https://ss64.com/nt/if.html): if errorlevel NUM checks if %errorlevel% if equal or greater then NUM (notice errorlevel is not dereferenced with % or !!)
But AFAIK the last 1 is unnecessary (exit /b will propagate the errorlevel). https://ss64.com/nt/exit.html
EXIT without an ExitCode acts the same as goto:eof and will not alter the %ERRORLEVEL%
addaleax
approved these changes
Jun 22, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM, but I think we want the same thing for the N-API addons?
Contributor
|
Landed in c403eeb |
Merged
bzoz
added a commit
to JaneaSystems/node
that referenced
this pull request
Aug 29, 2018
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #21155 to vcbuild.bat
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @addaleax @nodejs/build-files @nodejs/platform-windows