readline: fix freeze if keypress event throws#2107
Closed
rlidwka wants to merge 1 commit intonodejs:masterfrom
Closed
readline: fix freeze if keypress event throws#2107rlidwka wants to merge 1 commit intonodejs:masterfrom
keypress event throws#2107rlidwka wants to merge 1 commit intonodejs:masterfrom
Conversation
`emitKeys` is a generator which emits `keypress` events in an infinite loop. But if `keypress` event handler throws, the error stops the loop, leaving generator in a broken state. So this patch restarts the generator when an error occures.
Contributor
|
I agree that if LGTM |
Contributor
|
LGTM. |
rlidwka
added a commit
that referenced
this pull request
Jul 11, 2015
`emitKeys` is a generator which emits `keypress` events in an infinite loop. But if `keypress` event handler throws, the error stops the loop, leaving generator in a broken state. So this patch restarts the generator when an error occures. PR-URL: #2107 Reviewed-By: Christopher Monsanto <chris@monsan.to> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
Author
|
landed in bd01603 |
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Jul 17, 2015
Notable changes * src: Added a new `--track-heap-objects` flag to track heap object allocations for heap snapshots (Bradley Meck) nodejs#2135. * readline: Fixed a freeze that affected the repl if the keypress event handler threw (Alex Kocharin) nodejs#2107. * npm: Upgraded to v2.13.0, release notes can be found in https://github.com/npm/npm/releases/tag/v2.13.0 (Forrest L Norvell) nodejs#2152. PR-URL: nodejs#2189
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is described here: #1968
I consider
keypressevent in readline a public api, and if such a handler throws, readline should continue to work normally.Basically, I see are two good ways to deal with it:
Since everything in readline is synchronous now, adding
nextTickwould break things. So I went with option 1.This PR fixes a particular bug. But avoiding throwing in repl might still be a good idea. So PR #1968 might still make sense, but as a refactor, not a bugfix (I'll let someone else to review it though).
// cc: @monsanto