doc: add OS X to instead of only macOS#21033
Closed
XadillaX wants to merge 3 commits intonodejs:masterfrom
Closed
Conversation
The last OS X version is 10.11 El Captian, and the first macOS version is 10.12 Sierra. So >= 10.8 < 10.10 is called OS X and >= 10.10 is called OS X or macOS. Refs: https://en.wikipedia.org/wiki/MacOS#Release_history
nodejs-github-bot
added
build
silverwind
approved these changes
May 30, 2018
vsemozhetbyt
approved these changes
May 30, 2018
Contributor
Member
|
perhaps we should just explicitly refer to them by version of codename ranges? it might be less confusing |
Trott
previously requested changes
May 31, 2018
BUILDING.md
Outdated
| | GNU/Linux | Tier 1 | kernel >= 2.6.32, glibc >= 2.12 | x64, arm | | | ||
| | GNU/Linux | Tier 1 | kernel >= 3.10, glibc >= 2.17 | arm64 | | | ||
| | macOS | Tier 1 | >= 10.10 | x64 | | | ||
| | macOS / OS X | Tier 1 | >= 10.10 | x64 | | |
Member
There was a problem hiding this comment.
no spaces around the slashes here and elsewhere, please
trivikr
approved these changes
May 31, 2018
yorkie
suggested changes
May 31, 2018
BUILDING.md
Outdated
| | GNU/Linux | Tier 1 | kernel >= 2.6.32, glibc >= 2.12 | x64, arm | | | ||
| | GNU/Linux | Tier 1 | kernel >= 3.10, glibc >= 2.17 | arm64 | | | ||
| | macOS | Tier 1 | >= 10.10 | x64 | | | ||
| | macOS/OS X | Tier 1 | >= 10.10 | x64 | | |
Contributor
There was a problem hiding this comment.
Make alignment with other rows?
Contributor
apapirovski
added
the
author ready
jasnell
approved these changes
Jun 29, 2018
Member
|
Landed in d462f8c 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Jul 13, 2018
The last OS X version is 10.11 El Captian, and the first macOS version is 10.12 Sierra. So >= 10.8 < 10.10 is called OS X and >= 10.10 is called OS X or macOS. Refs: https://en.wikipedia.org/wiki/MacOS#Release_history PR-URL: #21033 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 14, 2018
The last OS X version is 10.11 El Captian, and the first macOS version is 10.12 Sierra. So >= 10.8 < 10.10 is called OS X and >= 10.10 is called OS X or macOS. Refs: https://en.wikipedia.org/wiki/MacOS#Release_history PR-URL: #21033 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jul 18, 2018
3 tasks
|
OS X to instead of only macOS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last OS X version is 10.11 El Captian, and the first macOS version
is 10.12 Sierra. So >= 10.8 < 10.10 is called OS X and >= 10.10 is
called OS X or macOS.
Refs: https://en.wikipedia.org/wiki/MacOS#Release_history
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes