build: add build targets for easier build/clean by kenny-y · Pull Request #20905 · nodejs/node

kenny-y · 2018-05-23T03:24:17Z

Adding new build targets: 'bench-addons' & 'bench-addons-clean'.
With these two, it'll be easier to manage the dependencies among
targets and easier to build/clean the addons which are being
used in benchmarking.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

richardlau · 2018-05-23T03:33:50Z

Makefile


+# Build required addons for benchmark before running it.
+.PHONY: bench-addons
+bench-addons: benchmark/misc/function_call/build/Release/binding.node


~~This was previously the bench-misc target, which was removed along with most of the bench-* targets in #18150.~~

Ref: #17053
cc @joyeecheung @nodejs/benchmarking

Edit: Sorry I can't read properly. At least this late at night.

The previous plan was to invoke node-gyp inside the benchmark, but I couldn't make the child process arguments work as intended.

Thanks for the info... so what's the preferred way? Are we taking this approach to do it in Makefile, or using node-gyp to make it be able to run under benchmark dir? I'm neutral to either one.

BTW. I do have something to add to the benchmark dir so I kicked off with the refactoring of this Makefile -- otherwise it'll be too annoying to build/clean a number of addons in benchmark

I think it'd be better if the building can be done inside the benchmark script, since that will be run on Windows, otherwise one will need to update vcbuild.bat for Windows to have this.

Trott · 2018-05-23T03:46:16Z

Personally, I'd prefer we didn't abbreviate "benchmark" to "bench" in the target names, although I know this PR didn't originate that. Just, you know, if someone wanted to change it in another PR, that would be A-OK by me.

kenny-y · 2018-05-23T04:09:48Z

The purpose of this PR is that (a) make the current mechanism better, e.g no longer need to key in make benchmark/misc/function_call/build/Release/binding.node to build, and no longer need to manually rm -rf benchmark/misc/function_call/build/ to clean; (b) if someone wants to add a new bindings benchmark (e.g. a napi-function-call comparing to the existing function-call), it'll be much easier for her/him/zem to manage the new node-gyp build (based on the new targets introduced in this PR).

BridgeAR

No strong opinion. Code LGTM

BridgeAR · 2018-05-28T13:35:35Z

@nodejs/build PTAL

gabrielschulhof · 2018-07-10T22:36:18Z

@nodejs/build PTAL

Trott · 2018-07-10T22:38:09Z

ping @nodejs/build-files

addaleax

I think I’d prefer just landing this as opposed to letting it stall.

CI: https://ci.nodejs.org/job/node-test-pull-request/15790/

kenny-y · 2018-07-11T00:13:37Z

Oops, I guess this PR is outdated (the dir of the target was moved elsewhere) and I will rebase it on top of most recent changes.

kenny-y · 2018-07-13T07:37:10Z

Push the same change again to trigger Travis again to see if it goes green this time (1 out 2 had failed: not ok 2312 sequential/test-inspector-port-zero-cluster)

Trott · 2018-07-13T11:54:52Z

Makefile

Not a blocking objection, but:

Currently, all make bench does is print a message telling people to run the tests manually instead, right?

This will build the addons and then tell the person to run their benchmarks manually?

Would it make more sense to not do that and just have people know they need to run make bench-addons if they are running one of the two benchmarks that require it? No one runs make bench anyway unless they stumble upon it. Compiling stuff and then printing a message saying, basically, "don't use this command" seems like something that could be improved.

Trott · 2018-07-13T11:56:03Z

Makefile

Should this be bench-addons-build instead, similar to (for example) lint-md-build? bench-addons makes it sound like it runs addons benchmarks. This just builds them but does not run them.

Good point.

With these two, it will be easier to manage the dependencies among targets and easier to build/clean the addons which are being used in benchmarking.

Trott · 2018-07-16T23:11:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/15901/

gabrielschulhof · 2018-07-19T18:36:42Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/15952/

gabrielschulhof · 2018-07-19T20:24:42Z

CI resumed as: https://ci.nodejs.org/job/node-test-pull-request/15954/

gabrielschulhof · 2018-07-20T00:02:52Z

Landed in 266c1f4.

Adding new build targets: 'bench-addons' & 'bench-addons-clean'. With these two, it will be easier to manage the dependencies among targets and easier to build/clean the addons which are being used in benchmarking. PR-URL: #20905 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label May 23, 2018

richardlau reviewed May 23, 2018

View reviewed changes

BridgeAR reviewed May 24, 2018

View reviewed changes

addaleax approved these changes Jul 10, 2018

View reviewed changes

kenny-y force-pushed the benchmark-addons-build branch 3 times, most recently from a9992f3 to 395a6a7 Compare July 13, 2018 07:35

Trott reviewed Jul 13, 2018

View reviewed changes

kenny-y force-pushed the benchmark-addons-build branch from 395a6a7 to d2123e9 Compare July 16, 2018 07:03

Adding new build targets: 'bench-addons' & 'bench-addons-clean'.

d2123e9

With these two, it will be easier to manage the dependencies among targets and easier to build/clean the addons which are being used in benchmarking.

Trott approved these changes Jul 16, 2018

View reviewed changes

gabrielschulhof closed this Jul 20, 2018

targos mentioned this pull request Jul 31, 2018

v10.8.0 proposal #22040

Merged

This was referenced Aug 1, 2018

2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-nodejs#212

Closed

2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-android-nodejs#223

Closed

2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-android-nodejs#224

Closed

This was referenced Aug 2, 2018

2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-android-nodejs#225

Closed

2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-android-nodejs#226

Closed

2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-android-nodejs#227

Closed

Uh oh!

Conversation

kenny-y commented May 23, 2018

Checklist

Uh oh!

richardlau May 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joyeecheung May 25, 2018

Choose a reason for hiding this comment

Uh oh!

kenny-y May 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joyeecheung May 28, 2018

Choose a reason for hiding this comment

Uh oh!

Trott commented May 23, 2018

Uh oh!

kenny-y commented May 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented May 28, 2018

Uh oh!

gabrielschulhof commented Jul 10, 2018

Uh oh!

Trott commented Jul 10, 2018

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

kenny-y commented Jul 11, 2018

Uh oh!

kenny-y commented Jul 13, 2018

Uh oh!

Trott Jul 13, 2018

Choose a reason for hiding this comment

Uh oh!

Trott Jul 13, 2018

Choose a reason for hiding this comment

Uh oh!

kenny-y Jul 16, 2018

Choose a reason for hiding this comment

Uh oh!

Trott commented Jul 16, 2018

Uh oh!

gabrielschulhof commented Jul 19, 2018

Uh oh!

gabrielschulhof commented Jul 19, 2018

Uh oh!

gabrielschulhof commented Jul 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

richardlau May 23, 2018 •

edited

Loading

kenny-y May 28, 2018 •

edited

Loading

kenny-y commented May 23, 2018 •

edited

Loading