inspector: get rid of the make_unique#20895
Merged
eugeneo merged 0 commit intonodejs:masterfrom May 22, 2018
eugeneo:no_make_unique
Merged
inspector: get rid of the make_unique#20895eugeneo merged 0 commit intonodejs:masterfrom eugeneo:no_make_unique
eugeneo merged 0 commit intonodejs:masterfrom
eugeneo:no_make_unique
Conversation
nodejs-github-bot
added
c++
Contributor
Author
3 tasks
addaleax
approved these changes
May 22, 2018
richardlau
approved these changes
May 22, 2018
Member
|
No objections to this as a workaround, but the real issue is that non-regular CI jobs like CitGM (nodejs/build#1254) are not using the same level of compilers as the normal Node.js CI runs. |
Contributor
|
Please also update |
Contributor
Author
|
@apapirovski Oops - forgot to also grep the subfolders. Done. |
apapirovski
approved these changes
May 22, 2018
TimothyGu
approved these changes
May 22, 2018
Contributor
Author
|
There's a number of test failures but none of them is inspector-related (and this change is basically compiler-time only) |
Contributor
Author
|
Landed as 7f610a1 |
MylesBorins
pushed a commit
that referenced
this pull request
May 23, 2018
PR-URL: #20895 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 23, 2018
PR-URL: #20895 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes