src: remove --expose-http2 option

[danbev]

This commit removes the --expose-http2 option. In the code comment it
states that this should should be noop through v9.x, and it sounds like
it can be removed for 10.x and above.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/15017/

[addaleax]

Still breaking if somebody uses the flag in 10.x and we remove it, right?

[danbev]

Still breaking if somebody uses the flag in 10.x and we remove it, right?

Oh yes, that is right. Thanks for adding the 10.x label!

[targos]

How about we put the semver-major label instead?

[targos]

There are also instances of the flag in the benchmark directory:

benchmark/http2/headers.js:}, { flags: ['--no-warnings', '--expose-http2'] });
benchmark/http2/respond-with-fd.js:}, { flags: ['--no-warnings', '--expose-http2'] });
benchmark/http2/simple.js:}, { flags: ['--no-warnings', '--expose-http2'] });
benchmark/http2/write.js:}, { flags: ['--no-warnings', '--expose-http2'] });

[danbev]

There are also instances of the flag in the benchmark directory

Thanks for that, will update shortly.

[danbev]

Landed in 3294d1b.