test: use error code rather than message in test#20859
test: use error code rather than message in test#20859Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Use err.code checking instead of err.message checking in test-child-process-fork-closed-channel-segfault.
Trott
added
child_process
|
CI: https://ci.nodejs.org/job/node-test-pull-request/14991/ This test is currently failing a lot on Windows already, and I don't have a good reason to believe this will fix that, but let's see what happens, I guess. |
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
This should have zero impact on the test outcome.
@BridgeAR Yes, that's my expectation. I wrote all that stuff about how the test is currently failing not because I expect this to fix it, but because I expect people (who aren't aware that the test is already failing more often than passing on Windows) to (understandably) think that this PR introduces a problem when it doesn't. This PR is a style improvement that also makes the test less brittle, but it does not address the test's current issues. If it ends up somehow mysteriously fixing the test's current problems, that will be unexpected for sure. |
|
Unrelated http2 test failures, re-running: LinxONE re-run: https://ci.nodejs.org/job/node-test-commit-linuxone/1459/ Might be futile until the test or underlying bug is fixed (as it fails roughly 80% of the time now), but Windows re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18143/ |
BridgeAR
added
the
author ready
|
FreeBSD re-run: https://ci.nodejs.org/job/node-test-commit-freebsd/17927/ |
|
FreeBSD is the only remaining platform needing green/yellow here: https://ci.nodejs.org/job/node-test-commit-freebsd/17929/ |
|
CI is all green/yellow now. Please 👍 here if you are in favor of fast-tracking. |
Use err.code checking instead of err.message checking in test-child-process-fork-closed-channel-segfault. PR-URL: nodejs#20859 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 4f0ab76 |
Use err.code checking instead of err.message checking in test-child-process-fork-closed-channel-segfault. PR-URL: #20859 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Use err.code checking instead of err.message checking in test-child-process-fork-closed-channel-segfault. PR-URL: #20859 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
12 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes