test: define SharedArrayBuffer as a known global#20849
Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
Closed
test: define SharedArrayBuffer as a known global#20849cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig wants to merge 1 commit intonodejs:masterfrom
Conversation
This commit defines SharedArrayBuffer as a global for all tests, rather than adding comments to individual tests.
TimothyGu
approved these changes
May 20, 2018
BridgeAR
approved these changes
May 20, 2018
hiroppy
approved these changes
May 20, 2018
addaleax
approved these changes
May 20, 2018
Member
BridgeAR
added
the
author ready
Member
|
+1 to fast-tracking, to be explicit about it. |
jasnell
approved these changes
May 20, 2018
benjamingr
approved these changes
May 20, 2018
tniessen
approved these changes
May 20, 2018
Member
|
Landed in 680a171 |
addaleax
pushed a commit
that referenced
this pull request
May 21, 2018
This commit defines SharedArrayBuffer as a global for all tests, rather than adding comments to individual tests. PR-URL: #20849 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
This commit defines SharedArrayBuffer as a global for all tests, rather than adding comments to individual tests. PR-URL: #20849 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 23, 2018
This commit defines SharedArrayBuffer as a global for all tests, rather than adding comments to individual tests. PR-URL: #20849 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit defines
SharedArrayBufferas a global for all tests, rather than adding comments to individual tests.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes