test: improve coverage for readline#20840
Closed
shisama wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Add tests for readline keys to improve coverage.
hiroppy
added
the
readline
cjihrig
approved these changes
May 20, 2018
jasnell
approved these changes
May 20, 2018
trivikr
approved these changes
May 20, 2018
trivikr
added
the
author ready
benjamingr
approved these changes
May 20, 2018
Member
|
CI: https://ci.nodejs.org/job/node-test-pull-request/14990/console @trivikr FYI [author ready] is used only after CI is started. |
Contributor
|
Landed in 731c55a |
apapirovski
pushed a commit
that referenced
this pull request
May 22, 2018
Add tests for readline keys to improve coverage. PR-URL: #20840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Add tests for readline keys to improve coverage. PR-URL: #20840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 23, 2018
Add tests for readline keys to improve coverage. PR-URL: #20840 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for readline keys to improve coverage.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes