test: rename and document tls test#20820
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Add a short description and one question to a TLS test. Also, rename it since the previous name might unintentionally evoke connotations to an internet meme that would generally not be considered appropriate in our context.
addaleax
commented
May 18, 2018
| } | ||
|
|
||
| // `ca1` is not actually necessary for the certificate validation -- maybe | ||
| // the fixtures should be written in a way that requires it? |
Member
Author
There was a problem hiding this comment.
@nodejs/crypto If somebody knows how to do this, or that this does actually not make any sense, please raise your hand. :)
benjamingr
approved these changes
May 18, 2018
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
LGTM, can also fast track IMO since it's just a rename + comments. (Would prefer a CI rather than a CI-lite though in case some OS has something quirky about the naming)
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-commit/18593/ I’m okay with fast-tracking but I don’t want to discourage people from answering the question in the added comment. 😄 |
addaleax
added
the
author ready
cjihrig
approved these changes
May 20, 2018
trivikr
approved these changes
May 20, 2018
Trott
approved these changes
May 21, 2018
jasnell
approved these changes
May 21, 2018
ryzokuken
approved these changes
May 21, 2018
Contributor
|
Landed in 3c10d57 |
apapirovski
pushed a commit
that referenced
this pull request
May 22, 2018
Add a short description and one question to a TLS test. Also, rename it since the previous name might unintentionally evoke connotations to an internet meme that would generally not be considered appropriate in our context. PR-URL: #20820 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Add a short description and one question to a TLS test. Also, rename it since the previous name might unintentionally evoke connotations to an internet meme that would generally not be considered appropriate in our context. PR-URL: #20820 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 23, 2018
Add a short description and one question to a TLS test. Also, rename it since the previous name might unintentionally evoke connotations to an internet meme that would generally not be considered appropriate in our context. PR-URL: #20820 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a short description and one question to a TLS test.
Also, rename it since the previous name might unintentionally
evoke connotations to an internet meme that would generally
not be considered appropriate in our context.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes