doc: improve _Deprecation_ definition#20788
Conversation
The definition and linked page looks to be under Creative Commons Attribution-ShareAlike 3.0 which has conditions of use. The quoted text appears to originate in http://openjdk.java.net/jeps/277. |
@richardlau From the license:
This is certainly an "applicable exception or limitation", specifically fair use. We are quoting less than two sentences. Fair use is one of the enumerated exceptions in the license FAQ. |
Trott
added
the
author ready
Trott
force-pushed
the
deprecation-definition
branch
from
6f86e05 to
e41a10c
Compare
|
Rebased to eliminate conflict and force-pushed. LIte CI: https://ci.nodejs.org/job/node-test-pull-request-lite/727/ |
COLLABORATOR_GUIDE.md
Outdated
There was a problem hiding this comment.
What's the difference between [_Deprecation_] and [_Deprecation_][]? I have seen both versions, but mostly the latter.
There was a problem hiding this comment.
I'd not noticed that the former worked. I meant to do the latter but made a mistake. I'll fix that.
COLLABORATOR_GUIDE.md
Outdated
There was a problem hiding this comment.
Is it common practice to omit spaces when using an ellipsis in English? (In German, it is not.)
There was a problem hiding this comment.
Judging from https://en.wikipedia.org/wiki/Ellipsis#In_American_English, practices vary. I'll add spaces on both sides of each ellipsis.
* Use definition from Wikipedia. Provide link.
* Use italics for "words-as-words".
* Simplify sentence. ("Deprecation is..." rather than "Deprecation refers
to...".)
Trott
force-pushed
the
deprecation-definition
branch
from
e41a10c to
4fe5c92
Compare
* Use definition from Wikipedia. Provide link.
* Use italics for "words-as-words".
* Simplify sentence. ("Deprecation is..." rather than "Deprecation
refers to...".)
PR-URL: nodejs#20788
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in df511c6 |
* Use definition from Wikipedia. Provide link.
* Use italics for "words-as-words".
* Simplify sentence. ("Deprecation is..." rather than "Deprecation
refers to...".)
PR-URL: #20788
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
8 participants
to...".)
Checklist