tools, doc: wrap manpage links in code elements#20785
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:backticks-in-manpages-links
Closed
tools, doc: wrap manpage links in code elements#20785vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:backticks-in-manpages-links
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:backticks-in-manpages-links
Conversation
nodejs-github-bot
added
doc
addaleax
approved these changes
May 16, 2018
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Contributor
Author
|
Sorry, I forgot to update the test. CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/720/ |
vsemozhetbyt
added
the
author ready
cjihrig
approved these changes
May 16, 2018
trivikr
approved these changes
May 17, 2018
jasnell
approved these changes
May 17, 2018
lpinca
approved these changes
May 17, 2018
vsemozhetbyt
added a commit
that referenced
this pull request
May 17, 2018
PR-URL: #20785 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
Author
|
Landed in e6b7f0e |
3 tasks
vsemozhetbyt
added a commit
that referenced
this pull request
May 20, 2018
After #20785, we wrap autogenerated manpage links in code elements. This PR unify some hardcoded manpage links with autogenerated ones: it adds backticks, parentheses, section numbers, and updates URLs. Also, some typos are fixes in passing (missing periods, reference sorting). PR-URL: #20854 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
PR-URL: #20785 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
After #20785, we wrap autogenerated manpage links in code elements. This PR unify some hardcoded manpage links with autogenerated ones: it adds backticks, parentheses, section numbers, and updates URLs. Also, some typos are fixes in passing (missing periods, reference sorting). PR-URL: #20854 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesBefore:
After: