doc: fix typo in COLLABORATOR_GUIDE.md by vsemozhetbyt · Pull Request #20742 · nodejs/node

vsemozhetbyt · 2018-05-15T08:39:52Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Refs: #20740

vsemozhetbyt · 2018-05-15T08:40:40Z

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/710/

vsemozhetbyt · 2018-05-15T08:48:04Z

cc @nodejs/linting How can we fix the linting issue in this case?

BridgeAR · 2018-05-15T10:08:39Z

@vsemozhetbyt good question... I guess it would actually be best to rename the group instead.

Ping @nodejs/tsc

ofrobots · 2018-05-15T18:20:48Z

{digression} IMHO, this doesn't need review from the TSC or even a ping to the list of all collaborators – this is an uncontroversial typo fix. Global pings should be avoided unless necessary. {/digression}

mhdawson

LGTM

Trott · 2018-05-15T18:49:48Z

How about we change the capitalization on the group name instead (and in the CODEOWNERS file too)? Then the linter will be happy and we'll have a group name that correctly styles the name V8. We've tried to use V8 everywhere to avoid confusion about v being for version and also just to be consistent with Google's styling for the JavaScript engine.

Trott · 2018-05-15T18:50:41Z

(@ofrobots I think the ping may have been automated by the CODEOWNERS file. It's possible we don't need a TSC ping for changes to COLLABORATOR_GUIDE. Basically only if it entails a governance change. Maybe that line can be removed from CODEOWNERS.)

Trott · 2018-05-15T18:51:26Z

I'd prefer we change the name of the team to use V8.

vsemozhetbyt · 2018-05-15T18:53:27Z

@ofrobots It seems the ping was not about typo itself: we have a conflict between linting rule requiring V8 case and the team name with v8. If we land it this way, we will have constant linting failures. If we leave it out, we will have broken team tag.

Trott · 2018-05-15T20:05:02Z

@vsemozhetbyt Are you 👍if I change the team name to use V8 instead of v8? Then we can close this PR and you (or I or anyone else) can update the CODEOWNERS file?

vsemozhetbyt · 2018-05-15T20:22:24Z

@Trott Yes, please, this seems more consistent.

Trott · 2018-05-15T20:52:44Z

It appears that GitHub has started (or maybe always has?) lowercasing team names in @-mentions regardless of how you actually name the team.

I'll see about updating the prohibited-strings code to ignore prohibited strings that appear inside of @-strings so this starts passing.

Trott · 2018-05-15T21:40:14Z

Published a new version of remark-lint-prohibited-strings to avoid the false positive here. Unfortunately, people will likely need to do make lint-md-clean && make lint-md-build after this lands to avoid getting the lint error.

I put the update as the first commit on this PR with the original changes as the second commit. (I recommend leaving them separate for what I hope are obvious reasons.)

Full CI (because now we're updating tools): https://ci.nodejs.org/job/node-test-pull-request/14895/

@vsemozhetbyt Thanks for your patience with this!

Trott · 2018-05-15T21:44:30Z

Hmmm...looks like I need to remove some OS-dependent stuff:

17:41:03 npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules/fsevents):
17:41:03 npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"freebsd","arch":"x64"})

Update to remark-lint-prohibited-strings 1.0.3 to avoid false positives with GitHub team names which must be lowercased no matter what our prohibited-strings rules say about a particular string.

Refs: #20740

Trott · 2018-05-15T21:49:12Z

CI: https://ci.nodejs.org/job/node-test-commit/18517/

Trott · 2018-05-15T22:05:42Z

Re-running arm-fanned, addons failure is clearly spurious: https://ci.nodejs.org/job/node-test-commit-arm-fanned/1230/

Trott · 2018-05-15T22:29:21Z

Got better results this time, but still some spurious ones in arm-fanned. Trying that one again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/1231/

Trott · 2018-05-15T22:49:51Z

I'm wondering if all my terminating of Pi jobs in process is what's causing the problem for arm-fanned. Going to let the last one finish this time. Again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/1232/

Trott · 2018-05-15T22:50:28Z

(Other than arm-fanned, CI is totally green.)

Trott · 2018-05-15T23:48:54Z

arm-fanned is green too now. Landing...

Trott · 2018-05-15T23:49:21Z

Oops, not landing because it hasn't been approved for fast-tracking.

vsemozhetbyt · 2018-05-15T23:51:17Z

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

devsnek · 2018-05-15T23:52:04Z

the first commit only modifies two package-lock.json files?

devsnek · 2018-05-15T23:55:15Z

@Trott is there not also a package.json to update?

Trott · 2018-05-15T23:58:04Z

@Trott is there not also a package.json to update?

It's not necessary, but there could be one. That would require publishing a new version of remark-preset-lint-node to change ^1.0.0 to ^1.0.3 in one line of the relevant package.json. Didn't seem worth it since npm install will grab 1.0.3 anyway. But, if you want, I'll totally do it if there might be something I'm missing or even if just for aesthetic reasons.

devsnek · 2018-05-16T00:01:31Z

@Trott if it isn't needed its fine, i was just confused when i saw lock files changed without the actual package changing is all

vsemozhetbyt · 2018-05-17T15:24:58Z

@Trott Are we good to land?

Update to remark-lint-prohibited-strings 1.0.3 to avoid false positives with GitHub team names which must be lowercased no matter what our prohibited-strings rules say about a particular string. PR-URL: nodejs#20742 Refs: nodejs#20740 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#20742 Refs: nodejs#20740 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR · 2018-05-18T14:07:07Z

Landed in 40469b4, 59f71ea 🎉

Trott · 2018-05-19T05:10:27Z

@Trott Are we good to land?

@vsemozhetbyt A belated "yes". :-D

Update to remark-lint-prohibited-strings 1.0.3 to avoid false positives with GitHub team names which must be lowercased no matter what our prohibited-strings rules say about a particular string. PR-URL: #20742 Refs: #20740 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #20742 Refs: #20740 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

vsemozhetbyt requested a review from a team as a code owner May 15, 2018 08:39

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 15, 2018

BridgeAR approved these changes May 15, 2018

View reviewed changes

cjihrig approved these changes May 15, 2018

View reviewed changes

mhdawson approved these changes May 15, 2018

View reviewed changes

trivikr approved these changes May 15, 2018

View reviewed changes

Trott and others added 2 commits May 15, 2018 14:47

tools: update prohibited-strings md linting

d231049

Update to remark-lint-prohibited-strings 1.0.3 to avoid false positives with GitHub team names which must be lowercased no matter what our prohibited-strings rules say about a particular string.

doc: fix typo in COLLABORATOR_GUIDE.md

265b97c

Refs: #20740

jasnell approved these changes May 17, 2018

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 18, 2018

BridgeAR closed this May 18, 2018

vsemozhetbyt deleted the doc-cc-typo branch May 18, 2018 15:31

Trott mentioned this pull request May 19, 2018

doc: fix linting error #20839

Closed

4 tasks

addaleax mentioned this pull request May 22, 2018

v10.2.0 proposal #20724

Merged

Uh oh!

Conversation

vsemozhetbyt commented May 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

vsemozhetbyt commented May 15, 2018

Uh oh!

vsemozhetbyt commented May 15, 2018

Uh oh!

BridgeAR commented May 15, 2018

Uh oh!

ofrobots commented May 15, 2018

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

vsemozhetbyt commented May 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented May 15, 2018

Uh oh!

vsemozhetbyt commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

Trott commented May 15, 2018

Uh oh!

vsemozhetbyt commented May 15, 2018

Uh oh!

devsnek commented May 15, 2018

Uh oh!

devsnek commented May 15, 2018

Uh oh!

Trott commented May 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devsnek commented May 16, 2018

Uh oh!

vsemozhetbyt commented May 17, 2018

Uh oh!

BridgeAR commented May 18, 2018

Uh oh!

Trott commented May 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

vsemozhetbyt commented May 15, 2018 •

edited

Loading

vsemozhetbyt commented May 15, 2018 •

edited

Loading

Trott commented May 15, 2018 •

edited

Loading