module: introduce defaultModuleName in module.js#20709
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
module: introduce defaultModuleName in module.js#20709danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
This commit adds a constant named defaultModuleName to avoid duplicating it in the Module constructor function.
Contributor
Author
hiroppy
approved these changes
May 14, 2018
trivikr
approved these changes
May 14, 2018
devsnek
approved these changes
May 14, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
May 14, 2018
Contributor
Author
|
Landed in ea01d30. |
danbev
added a commit
that referenced
this pull request
May 16, 2018
This commit adds a constant named defaultModuleName to avoid duplicating it in the Module constructor function. PR-URL: #20709 Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
This commit adds a constant named defaultModuleName to avoid duplicating it in the Module constructor function. PR-URL: #20709 Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a constant named defaultModuleName to avoid duplicating
it in the Module constructor function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes