Closed
Conversation
This commit makes the currently protected members env_ and context_ private in node_contextify.h.
nodejs-github-bot
added
c++
Contributor
Author
TimothyGu
approved these changes
May 11, 2018
addaleax
approved these changes
May 11, 2018
addaleax
added
the
author ready
cjihrig
approved these changes
May 11, 2018
tniessen
approved these changes
May 11, 2018
jasnell
approved these changes
May 12, 2018
Contributor
Author
|
Landed in fcf2e42. |
danbev
added a commit
that referenced
this pull request
May 14, 2018
This commit makes the currently protected members env_ and context_ private in node_contextify.h. PR-URL: #20671 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
May 14, 2018
This commit makes the currently protected members env_ and context_ private in node_contextify.h. PR-URL: #20671 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes the currently protected members env_ and context_
private in node_contextify.h.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes